From: Ingo Molnar <mingo@elte.hu>
To: Tejun Heo <tj@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Yinghai Lu <yinghai@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] Reverting NUMA-affine page table allocation
Date: Wed, 2 Mar 2011 19:31:23 +0100 [thread overview]
Message-ID: <20110302183123.GE13693@elte.hu> (raw)
In-Reply-To: <20110302182551.GB28266@mtj.dyndns.org>
* Tejun Heo <tj@kernel.org> wrote:
> On Wed, Mar 02, 2011 at 07:19:41PM +0100, Ingo Molnar wrote:
> > Hm, i thought the revert was for tip:x86/mm, not x86/urgent. The development window
> > for 2.6.39 is closing down.
> >
> > A revert (without an actual bug that it fixes) for -rc8 is definitely out of
> > question.
>
> It is for x86/mm and it does address the unnecessarily smaller mapping
> problem, which Yinghai's further patches address too. Those patches
> are what triggered me to ask for a revert because they kinda show how
> ugly the underlying code is and add on top of it.
Yeah - i agree with you and hpa that deferring this to .40 is the most sensible
approach.
The splitting up into small regions side-effect was rather nasty to begin with - it
would have taken who knows how many cycles for someone to notice that based on raw
analysis of the pagetables ...
We need to slow down here for .39.
Thanks,
Ingo
next prev parent reply other threads:[~2011-03-02 18:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 14:37 [RFC] Reverting NUMA-affine page table allocation Tejun Heo
2011-03-01 8:30 ` Tejun Heo
2011-03-01 22:41 ` Yinghai Lu
2011-03-02 16:19 ` Tejun Heo
2011-03-02 16:47 ` Yinghai Lu
2011-03-02 17:07 ` Tejun Heo
2011-03-02 18:08 ` Ingo Molnar
2011-03-02 18:12 ` H. Peter Anvin
2011-03-02 18:19 ` Ingo Molnar
2011-03-02 18:25 ` Tejun Heo
2011-03-02 18:31 ` Ingo Molnar [this message]
2011-03-02 18:32 ` Ingo Molnar
2011-03-02 18:22 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302183123.GE13693@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox