From: Dan Carpenter <error27@gmail.com>
To: Roel Van Nyen <roel.vannyen@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, acho@novell.com
Subject: Re: [PATCH] Staging: keucr: Remove all type defines
Date: Wed, 2 Mar 2011 22:37:41 +0300 [thread overview]
Message-ID: <20110302193741.GO18043@bicker> (raw)
In-Reply-To: <20110302192023.GA2112@roel-laptop>
On Wed, Mar 02, 2011 at 08:20:23PM +0100, Roel Van Nyen wrote:
> On Tue, Mar 01, 2011 at 11:00:06PM +0300, Dan Carpenter wrote:
> > On Tue, Mar 01, 2011 at 08:29:50PM +0100, Roel Van Nyen wrote:
> > > -typedef u8 BOOLEAN;
> >
> > It might be better to use bool type or int for boolean variables. But
> > that can't be done automatically, it has to be audited carefully. I
> > don't feel strongly about this, I'm just throwing it out there as food
> > for thought. You are using the remove-typedef program btw?
>
> I did not use the remove-typedef program, I used perl regex. (btw: where is that, i could not find it)
I just saw Luis R. Rodriguez mention it. I hadn't heard of it before.
http://www.kernel.org/pub/linux/kernel/people/mcgrof/scripts/remove-typedef
> I will post a patchset later tonight wich contains the removal of all the types from this driver.
> The first patch will contain the removal of all types except the BOOLEAN.
> In the second one I will remove the boolean and check where to make it an integer and where a bool.
Sounds good.
regards,
dan carpenter
prev parent reply other threads:[~2011-03-02 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 19:29 [PATCH] Staging: keucr: Remove all type defines Roel Van Nyen
2011-03-01 20:00 ` Dan Carpenter
2011-03-02 19:20 ` Roel Van Nyen
2011-03-02 19:37 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302193741.GO18043@bicker \
--to=error27@gmail.com \
--cc=acho@novell.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.vannyen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox