Re: [PATCH 2/2] Staging: keucr: Remove BOOLEAN type from driver.

Greg KH
2011-03-02T21:35:04Z

On Wed, Mar 02, 2011 at 10:18:13PM +0100, Roel Van Nyen wrote:
> On Wed, Mar 02, 2011 at 10:12:15PM +0100, Belisko Marek wrote:
> > On Wed, Mar 2, 2011 at 10:04 PM, Roel Van Nyen <roel.vannyen@gmail.com> wrote:
> > > Remove BOOLEAN type, replacing it with bool and removing some that were not in use.
> > >
> > > Signed-off-by: Roel Van Nyen <roel.vannyen@gmail.com>
> > > ---
> > >  drivers/staging/keucr/common.h   |    2 --
> > >  drivers/staging/keucr/smil.h     |    4 ++--
> > >  drivers/staging/keucr/smilmain.c |    4 ++--
> > >  drivers/staging/keucr/usb.h      |    4 +---
> > >  4 files changed, 5 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/drivers/staging/keucr/common.h b/drivers/staging/keucr/common.h
> > > index 07aabf4..5dda691 100644
> > > --- a/drivers/staging/keucr/common.h
> > > +++ b/drivers/staging/keucr/common.h
> > > @@ -1,8 +1,6 @@
> > >  #ifndef COMMON_INCD
> > >  #define COMMON_INCD
> > >
> > > -typedef u8 BOOLEAN;
> > > -
> > >  #define swapWORD(w)    ((((unsigned short)(w) << 8) & 0xff00) |        \
> > >                         (((unsigned short)(w) >> 8) & 0x00ff))
> > >  #define swapDWORD(dw)  ((((unsigned long)(dw) << 24) & 0xff000000) |   \
> > > diff --git a/drivers/staging/keucr/smil.h b/drivers/staging/keucr/smil.h
> > > index c108545..a3addff 100644
> > > --- a/drivers/staging/keucr/smil.h
> > > +++ b/drivers/staging/keucr/smil.h
> > > @@ -223,11 +223,11 @@ int         Media_D_OneSectWriteNext    (struct us_data *,u8 *);
> > >  int         Media_D_OneSectWriteFlush   (struct us_data *);
> > >
> > >  /******************************************/
> > > -void        SM_EnableLED                (struct us_data *,BOOLEAN);
> > > +void        SM_EnableLED                (struct us_data *, bool enabled);
> > >  void        Led_D_TernOn                (void);
> > >  void        Led_D_TernOff               (void);
> > >
> > > -int         Media_D_EraseAllRedtData    (u32 Index, BOOLEAN CheckBlock);
> > > +int         Media_D_EraseAllRedtData    (u32 Index);
> > Shouldn't there be something like:
> > int Media_D_EraseAllRedtData (u32 Index, bool CheckBlock); ???
> no, since the variable was not used in the first place.

That's fine, but don't do that in this patch.

Remember, do only one thing per patch, don't bury code changes in a
"remove typedefs" patch, that's not allowed at all.

sorry,

greg k-h