From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: linux-usb@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Ozan Caglayan <ozan@pardus.org.tr>
Subject: [PATCH 2/2] PCI/ACPI: Report MSI support to BIOS if not disabled from command line
Date: Wed, 2 Mar 2011 23:33:23 +0100 [thread overview]
Message-ID: <201103022333.23919.rjw@sisk.pl> (raw)
In-Reply-To: <201103022330.49297.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
We need to distinguish the situation in which MSI support is disabled
from the command line or through .config from the situation in which
it is disabled, because the hardware or BIOS can't handle it. In the
former case we should not report MSI support to the BIOS through ACPI
_OSC, but in the latter case we should do that.
Introduce pci_msi_support_enabled() that can be used by
acpi_pci_root_add() to determine whether or not it should report MSI
support to the BIOS through _OSC.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/acpi/pci_root.c | 2 +-
drivers/pci/msi.c | 12 ++++++++++++
drivers/pci/pci.c | 2 +-
drivers/pci/pci.h | 2 ++
include/linux/pci.h | 3 +++
5 files changed, 19 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/pci/msi.c
===================================================================
--- linux-2.6.orig/drivers/pci/msi.c
+++ linux-2.6/drivers/pci/msi.c
@@ -24,6 +24,7 @@
#include "msi.h"
static int pci_msi_enable = 1;
+static bool msi_support_enabled = true;
/* Arch hooks */
@@ -855,6 +856,17 @@ void pci_no_msi(void)
pci_msi_enable = 0;
}
+void pci_no_msi_support(void)
+{
+ msi_support_enabled = false;
+ pci_no_msi();
+}
+
+bool pci_msi_support_enabled(void)
+{
+ return msi_support_enabled;
+}
+
/**
* pci_msi_enabled - is MSI enabled?
*
Index: linux-2.6/drivers/pci/pci.c
===================================================================
--- linux-2.6.orig/drivers/pci/pci.c
+++ linux-2.6/drivers/pci/pci.c
@@ -3062,7 +3062,7 @@ static int __init pci_setup(char *str)
*k++ = 0;
if (*str && (str = pcibios_setup(str)) && *str) {
if (!strcmp(str, "nomsi")) {
- pci_no_msi();
+ pci_no_msi_support();
} else if (!strcmp(str, "noaer")) {
pci_no_aer();
} else if (!strcmp(str, "nodomains")) {
Index: linux-2.6/include/linux/pci.h
===================================================================
--- linux-2.6.orig/include/linux/pci.h
+++ linux-2.6/include/linux/pci.h
@@ -446,11 +446,14 @@ static inline bool pci_is_root_bus(struc
}
#ifdef CONFIG_PCI_MSI
+extern bool pci_msi_support_enabled(void);
+
static inline bool pci_dev_msi_enabled(struct pci_dev *pci_dev)
{
return pci_dev->msi_enabled || pci_dev->msix_enabled;
}
#else
+static inline bool pci_msi_support_enabled(void) { return false; }
static inline bool pci_dev_msi_enabled(struct pci_dev *pci_dev) { return false; }
#endif
Index: linux-2.6/drivers/acpi/pci_root.c
===================================================================
--- linux-2.6.orig/drivers/acpi/pci_root.c
+++ linux-2.6/drivers/acpi/pci_root.c
@@ -567,7 +567,7 @@ static int __devinit acpi_pci_root_add(s
if (pcie_aspm_support_enabled())
flags |= OSC_ACTIVE_STATE_PWR_SUPPORT |
OSC_CLOCK_PWR_CAPABILITY_SUPPORT;
- if (pci_msi_enabled())
+ if (pci_msi_support_enabled())
flags |= OSC_MSI_SUPPORT;
if (flags != base_flags)
acpi_pci_osc_support(root, flags);
Index: linux-2.6/drivers/pci/pci.h
===================================================================
--- linux-2.6.orig/drivers/pci/pci.h
+++ linux-2.6/drivers/pci/pci.h
@@ -140,9 +140,11 @@ extern unsigned int pci_pm_d3_delay;
#ifdef CONFIG_PCI_MSI
void pci_no_msi(void);
+extern void pci_no_msi_support(void);
extern void pci_msi_init_pci_dev(struct pci_dev *dev);
#else
static inline void pci_no_msi(void) { }
+static inline void pci_no_msi_support(void) { }
static inline void pci_msi_init_pci_dev(struct pci_dev *dev) { }
#endif
next prev parent reply other threads:[~2011-03-02 22:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 1:42 2.6.38 regression caused by commit 415e12b Sarah Sharp
2011-02-28 5:34 ` Sarah Sharp
2011-02-28 20:29 ` Rafael J. Wysocki
2011-03-01 18:31 ` Sarah Sharp
2011-03-01 20:55 ` Rafael J. Wysocki
2011-03-01 22:51 ` Sarah Sharp
2011-03-01 23:30 ` Rafael J. Wysocki
2011-03-02 0:04 ` Sarah Sharp
2011-03-02 0:17 ` Rafael J. Wysocki
2011-03-02 3:42 ` Sarah Sharp
2011-03-02 11:21 ` Rafael J. Wysocki
2011-03-02 22:30 ` [PATCH 0/2] " Rafael J. Wysocki
2011-03-02 22:32 ` [PATCH 1/2] PCI/ACPI: Report ASPM support to BIOS if not disabled from command line Rafael J. Wysocki
2011-03-02 22:33 ` Rafael J. Wysocki [this message]
2011-03-04 17:52 ` [PATCH 0/2] Re: 2.6.38 regression caused by commit 415e12b Sarah Sharp
2011-03-04 20:32 ` Rafael J. Wysocki
2011-03-14 23:56 ` Sarah Sharp
2011-03-15 0:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103022333.23919.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ozan@pardus.org.tr \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox