public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Tom Zanussi <tzanussi@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: [GIT PULL] tracepoints filtering updates
Date: Thu, 3 Mar 2011 04:51:23 +0100	[thread overview]
Message-ID: <20110303035121.GA3456@nowhere> (raw)
In-Reply-To: <20110302084925.GA21204@elte.hu>

On Wed, Mar 02, 2011 at 09:49:25AM +0100, Ingo Molnar wrote:
> 
> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 
> > We currently set the filters after we mmap the events, this is a
> > race that let undesired events record themselves in the buffer before
> > we had the time to set the filters.
> > 
> > So set the filters before they can be recorded. That also librarizes
> > the filters setting so that filtering can be done more easily
> > from other tools than perf record later.
> > 
> > (PS: This should fix most of the bugs Ingo has reported
> > about filters that weren't working with perf).
> 
> Nice!
> 
> Mind pulling Steve's filter-enhancements branch and sending a pull request for the 
> whole thing? Steve's branch was:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git tip/perf/filter
> 
> ( Or your fixes could be applied to Steve's branch as well - whichever direction you 
>   guys prefer - the important thing is to have filtering tested and validated as a 
>   whole. )
> 
> Thanks,
> 
> 	Ingo

Ok, I've merged Steve's branch and tested a few common filters with perf:

* irq numbers on irq tracepoints
* fd on sys_enter_close
* prev_comm on sched_switch (to test string)

they all work well.

You can pull the branch from:

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
	perf/core

--
Frederic Weisbecker (2):
      perf: Set filters before mmaping events
      Merge branch '/tip/perf/filter' of git://git.kernel.org/.../rostedt/linux-2.6-trace.git into perf/core

Steven Rostedt (14):
      tracing/filter: Have no filter return a match
      tracing/filter: Move OR and AND logic out of fn() method
      tracing/filter: Dynamically allocate preds
      tracing/filter: Call synchronize_sched() just once for system filters
      tracing/filter: Allocate the preds in an array
      tracing/filter: Free pred array on disabling of filter
      tracing/filter: Use a tree instead of stack for filter_match_preds()
      tracing/filter: Optimize short ciruit check
      tracing/filter: Check the created pred tree
      tracing/filter: Optimize filter by folding the tree
      tracing/filter: Move MAX_FILTER_PRED to local tracing directory
      tracing/filter: Increase the max preds to 2^14
      tracing/filter: Swap entire filter of events
      tracing/filter: Remove synchronize_sched() from __alloc_preds()
--
 include/linux/ftrace_event.h       |    1 -
 kernel/trace/trace.h               |   38 ++-
 kernel/trace/trace_events_filter.c |  885 +++++++++++++++++++++++++++++-------
 tools/perf/builtin-record.c        |   18 +-
 tools/perf/util/evlist.c           |   28 ++
 tools/perf/util/evlist.h           |    1 +
 6 files changed, 789 insertions(+), 182 deletions(-)

  reply	other threads:[~2011-03-03  3:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-26  4:03 [PATCH] perf: Set filters before mmaping events Frederic Weisbecker
2011-03-02  8:49 ` Ingo Molnar
2011-03-03  3:51   ` Frederic Weisbecker [this message]
2011-03-03  7:10     ` [GIT PULL] tracepoints filtering updates Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110303035121.GA3456@nowhere \
    --to=fweisbec@gmail.com \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox