From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757858Ab1CCIXP (ORCPT ); Thu, 3 Mar 2011 03:23:15 -0500 Received: from mga09.intel.com ([134.134.136.24]:13732 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754085Ab1CCIR4 (ORCPT ); Thu, 3 Mar 2011 03:17:56 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.62,257,1297065600"; d="scan'208";a="608559341" Message-Id: <20110303074948.803361297@intel.com> User-Agent: quilt/0.48-1 Date: Thu, 03 Mar 2011 14:45:06 +0800 From: Wu Fengguang To: Andrew Morton CC: Jan Kara , Wu Fengguang CC: Christoph Hellwig CC: Trond Myklebust CC: Dave Chinner CC: "Theodore Ts'o" CC: Chris Mason CC: Peter Zijlstra CC: Mel Gorman CC: Rik van Riel CC: KOSAKI Motohiro CC: Greg Thelen CC: Minchan Kim CC: Vivek Goyal CC: Andrea Righi CC: Balbir Singh Cc: linux-mm Cc: Cc: LKML Subject: [PATCH 01/27] writeback: add bdi_dirty_limit() kernel-doc References: <20110303064505.718671603@intel.com> Content-Disposition: inline; filename=writeback-task_dirty_limit-comment.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clarify the bdi_dirty_limit() comment. Signed-off-by: Wu Fengguang --- mm/page-writeback.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) --- linux-next.orig/mm/page-writeback.c 2011-03-03 14:38:12.000000000 +0800 +++ linux-next/mm/page-writeback.c 2011-03-03 14:40:52.000000000 +0800 @@ -437,10 +437,17 @@ void global_dirty_limits(unsigned long * *pdirty = dirty; } -/* +/** * bdi_dirty_limit - @bdi's share of dirty throttling threshold + * @bdi: the backing_dev_info to query + * @dirty: global dirty limit in pages + * + * Returns @bdi's dirty limit in pages. The term "dirty" in the context of + * dirty balancing includes all PG_dirty, PG_writeback and NFS unstable pages. + * And the "limit" in the name is not seriously taken as hard limit in + * balance_dirty_pages(). * - * Allocate high/low dirty limits to fast/slow devices, in order to prevent + * It allocates high/low dirty limits to fast/slow devices, in order to prevent * - starving fast devices * - piling up dirty pages (that will take long time to sync) on slow devices *