public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Borislav Petkov <bp@amd64.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>, x86 <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] x86, amd-nb: Misc correctness fixes
Date: Thu, 3 Mar 2011 10:14:40 +0100	[thread overview]
Message-ID: <20110303091440.GA18252@elte.hu> (raw)
In-Reply-To: <20110302193855.GA3840@aftab>


* Borislav Petkov <bp@amd64.org> wrote:

> Make functions used strictly in bool context return bool. Also, fixup
> used types and comments, and make a local function static, while at it.
> 
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>

I'm confused about the title - a 'correctness fix' is one that fixes an actual bug.

Did you mean 'cleanliness fixes'?

Also, checkpatch outputs a warning that looks legit.

Thanks,

	Ingo

  reply	other threads:[~2011-03-03  9:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02 19:38 [PATCH RESEND] x86, amd-nb: Misc correctness fixes Borislav Petkov
2011-03-03  9:14 ` Ingo Molnar [this message]
2011-03-03 11:59   ` Borislav Petkov
2011-03-03 12:05     ` Ingo Molnar
2011-03-03 12:33     ` [tip:x86/amd-nb] x86, amd-nb: Misc cleanliness fixes tip-bot for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110303091440.GA18252@elte.hu \
    --to=mingo@elte.hu \
    --cc=bp@amd64.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox