From: Arnd Bergmann <arnd@arndb.de>
To: "Kirill A. Shutsemov" <kirill@shutemov.name>
Cc: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
containers@lists.linux-foundation.org,
jacob.jun.pan@linux.intel.com,
Arjan van de Ven <arjan@linux.intel.com>,
linux-kernel@vger.kernel.org, Matt Helsley <matthltc@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-api@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH, v8 1/3] hrtimer: introduce effective timer slack
Date: Thu, 3 Mar 2011 17:32:28 +0100 [thread overview]
Message-ID: <201103031732.28964.arnd@arndb.de> (raw)
In-Reply-To: <1299161947-9903-2-git-send-email-kirill@shutemov.name>
On Thursday 03 March 2011, Kirill A. Shutsemov wrote:
> task_get_effective_timer_slack() returns timer slack value to be used
> to configure per-task timers. It can be equal or higher than task's
> timer slack value.
>
> For now task_get_effective_timer_slack() returns timer_slack_ns of the
> task. Timer slack cgroup controller will implement a bit more
> sophisticated logic.
Some time ago, there was a discussion about a method for automatically
determining timer slack values, and I think nobody ever implemented it.
The idea was to penalize tasks that have timers expiring a lot, typically
a sign of programs that were not written with power consumption in mind.
I think that could be nicely combined with your patch. Instead of setting
the effective timer slack for the entire control group, you could
set a target value that is applied only to tasks that have their timers
expire frequently. When a timer expires for a task, you increase the
effective slack up to the maximum, and when you set up a timer, you
decrease it again. The amount by which the effective slack gets changed
can depend on how long ago the last timer expired.
Does this make sense to you?
Arnd
next prev parent reply other threads:[~2011-03-03 16:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 14:19 [PATCH, v8 0/3] *** SUBJECT HERE *** Kirill A. Shutsemov
2011-03-03 14:19 ` [PATCH, v8 1/3] hrtimer: introduce effective timer slack Kirill A. Shutsemov
2011-03-03 16:32 ` Arnd Bergmann [this message]
2011-03-04 12:20 ` Kirill A. Shutemov
2011-03-04 12:55 ` Arnd Bergmann
2011-03-03 14:19 ` [PATCH, v8 2/3] hrtimer: implement PR_GET_EFFECTIVE_TIMERSLACK Kirill A. Shutsemov
2011-03-03 14:19 ` [PATCH, v8 3/3] cgroups: introduce timer slack controller Kirill A. Shutsemov
2011-03-07 23:19 ` Andrew Morton
2011-03-03 14:20 ` [PATCH, v8 0/3] *** SUBJECT HERE *** Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103031732.28964.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=containers@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=matthltc@us.ibm.com \
--cc=menage@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox