public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <pzijlstr@redhat.com>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Bharata B Rao <bharata.rao@in.ibm.com>
Subject: Re: [BUGFIX][PATCH] Fix sched rt group scheduling when hierachy is enabled
Date: Fri, 4 Mar 2011 12:55:17 +0530	[thread overview]
Message-ID: <20110304072517.GC2868@balbir.in.ibm.com> (raw)
In-Reply-To: <AANLkTikqC=MNXXavJ_jxhFNQz1uNdABXVhvj82HW=BNA@mail.gmail.com>

* Yong Zhang <yong.zhang0@gmail.com> [2011-03-04 11:43:16]:

> On Thu, Mar 3, 2011 at 11:29 PM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > No, not really :) It is required, it is a backup check to see if we
> > have queued tasks, rt_time of 0 and the runqueue is not throttled, why
> > should it be dequeued?
> 
> But I can't see where that kind of rt_rq is dequeued, mind pointing it out?
>

So here is what I saw

1. sched_dequeue_stack called from the dequeue path dequeues the
queues and sets rt_nr_running to 0
2. Enqueuing fails because rt_throttled is set for the group_rq
(parent who is throttled)
3. This causes further enqueue to fail, since rt_nr_running did
not increment in step 2, eventually the timer decrements rt_time
to 0 and the task is never picked up.

-- 
	Three Cheers,
	Balbir

  reply	other threads:[~2011-03-04  7:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 11:34 [BUGFIX][PATCH] Fix sched rt group scheduling when hierachy is enabled Balbir Singh
2011-03-03 14:05 ` Yong Zhang
2011-03-03 15:29   ` Balbir Singh
2011-03-04  3:43     ` Yong Zhang
2011-03-04  7:25       ` Balbir Singh [this message]
2011-03-04  8:32         ` Yong Zhang
2011-03-04  8:35           ` Balbir Singh
2011-03-04  8:52             ` Yong Zhang
2011-03-04  8:59               ` Balbir Singh
2011-03-04  9:30                 ` Yong Zhang
2011-03-04 12:11                   ` Balbir Singh
2011-03-07  7:00                     ` Yong Zhang
2011-03-08  8:42                       ` Yong Zhang
2011-03-08 18:34                         ` Balbir Singh
2011-03-04 11:49 ` [tip:sched/core] sched: " tip-bot for Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110304072517.GC2868@balbir.in.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=bharata.rao@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pzijlstr@redhat.com \
    --cc=vatsa@linux.vnet.ibm.com \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox