From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2] x86: early_quirk check all bus/dev/func in domain 0
Date: Fri, 4 Mar 2011 10:20:12 -0800 [thread overview]
Message-ID: <20110304102012.3ef9e7b2@jbarnes-desktop> (raw)
In-Reply-To: <4D506EDC.2070609@kernel.org>
On Mon, 07 Feb 2011 14:14:52 -0800
Yinghai Lu <yinghai@kernel.org> wrote:
>
> When we have 00:1a.0, 00:1a.1, 00:1a.2, 00:1a.7
> Found only 00:1a.0, and 00:1a.1 get processed. and 00:1a.2 and 00:1a.7 get skipped.
>
> We should only check header type on func0.
> Also should not bail out when have gap.
>
> At last try to process bus 00 - 0xff instead of only bus 00.
>
> -v2: check with VENDOR_ID instead of CLASS_DEVICE for invalid device.
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
I need a much better changelog here. It sounds (and looks) like the
patch is doing several things:
- processing more than the first two functions on a device
- processing the full set of busses in the first domain
- checking for nonexistent devices
Why are you making these changes? Do you have a system that needs
early quirks but violates the existing assumptions? Can you apply a
standard quirk instead?
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2011-03-04 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 22:14 [PATCH -v2] x86: early_quirk check all bus/dev/func in domain 0 Yinghai Lu
2011-03-04 18:20 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304102012.3ef9e7b2@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox