From: Don Zickus <dzickus@redhat.com>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/05] use proc_dointvec_minmax to check boundaries while needed
Date: Fri, 4 Mar 2011 09:04:04 -0500 [thread overview]
Message-ID: <20110304140404.GK11359@redhat.com> (raw)
In-Reply-To: <AANLkTi=sz7By1HaJ+HhFaQDWyUnrR5PNyAcL0uPnEt-K@mail.gmail.com>
On Fri, Mar 04, 2011 at 09:41:59AM +0800, Dave Young wrote:
> On Thu, Mar 3, 2011 at 10:59 PM, Don Zickus <dzickus@redhat.com> wrote:
> > On Thu, Mar 03, 2011 at 09:58:20PM +0800, Dave Young wrote:
> >> proc_dointvec doesn't check extra minmax params, use proc_dointvec_minmax
> >> instead of proc_dointvec for cases need boundaries check.
> >
> > Is this patch needed, if you are basically changing it again in patches 3
> > and 5?
>
> Sure if 3 and 5 is acked, if someone object them then this is good?
Ok. I guess I would have posted patches 2-4 first to get everyone's
opinion. Then if the reaction was negative, try with patch 1.
Personally I don't see any problems with patches 2-4. Then again I don't
deal with sysctl that much, so I don't what rules there are in that area of
code.
Cheers,
Don
next prev parent reply other threads:[~2011-03-04 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 13:58 [PATCH 01/05] use proc_dointvec_minmax to check boundaries while needed Dave Young
2011-03-03 14:59 ` Don Zickus
2011-03-04 1:41 ` Dave Young
2011-03-04 14:04 ` Don Zickus [this message]
2011-03-04 15:21 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304140404.GK11359@redhat.com \
--to=dzickus@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox