From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/6] ACPI / PM: Do not switch interrupts off/on in acpi_suspend_enter()
Date: Fri, 4 Mar 2011 16:37:37 +0100 [thread overview]
Message-ID: <20110304153737.GD1358@ucw.cz> (raw)
In-Reply-To: <201102072319.10327.rjw@sisk.pl>
Hi!
> The function acpi_suspend_enter() is always called with interrupts
> off, so it doesn't need to switch them off and on.
Maybe add 'this function always runs with irqs disabled' comment?
Otherwise ack.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2011-03-04 15:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 22:16 [PATCH 0/6] ACPI / PM: Simplifications of core suspend and hibernate code Rafael J. Wysocki
2011-02-07 22:18 ` [PATCH 1/6] ACPI / PM: Drop acpi_restore_state_mem() Rafael J. Wysocki
2011-03-04 15:35 ` Pavel Machek
2011-02-07 22:19 ` [PATCH 2/6] ACPI / PM: Do not switch interrupts off/on in acpi_suspend_enter() Rafael J. Wysocki
2011-03-04 15:37 ` Pavel Machek [this message]
2011-02-07 22:19 ` [PATCH 3/6] ACPI / PM: Modify the "low-level resume finished" message Rafael J. Wysocki
2011-03-04 15:38 ` Pavel Machek
2011-03-04 20:53 ` Rafael J. Wysocki
2011-02-07 22:20 ` [PATCH 4/6] ACPI / PM: Call acpi_save_state_mem() right before low-level suspend Rafael J. Wysocki
2011-03-04 15:38 ` Pavel Machek
2011-02-07 22:21 ` [PATCH 5/6] ACPI / PM: Merge do_suspend_lowlevel() into acpi_save_state_mem() Rafael J. Wysocki
2011-03-04 15:38 ` Pavel Machek
2011-02-07 22:22 ` [PATCH 6/6] ACPI / PM: Do not switch interrupts off/on in acpi_hibernation_enter() Rafael J. Wysocki
2011-03-04 15:39 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304153737.GD1358@ucw.cz \
--to=pavel@ucw.cz \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox