From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759730Ab1CDPiD (ORCPT ); Fri, 4 Mar 2011 10:38:03 -0500 Received: from ksp.mff.cuni.cz ([195.113.26.206]:40996 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759345Ab1CDPiB (ORCPT ); Fri, 4 Mar 2011 10:38:01 -0500 Date: Fri, 4 Mar 2011 16:37:37 +0100 From: Pavel Machek To: "Rafael J. Wysocki" Cc: Len Brown , LKML , ACPI Devel Mailing List , Linux PM mailing list , Ingo Molnar Subject: Re: [PATCH 2/6] ACPI / PM: Do not switch interrupts off/on in acpi_suspend_enter() Message-ID: <20110304153737.GD1358@ucw.cz> References: <201102072316.41270.rjw@sisk.pl> <201102072319.10327.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201102072319.10327.rjw@sisk.pl> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > The function acpi_suspend_enter() is always called with interrupts > off, so it doesn't need to switch them off and on. Maybe add 'this function always runs with irqs disabled' comment? Otherwise ack. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html