From: Dan Carpenter <error27@gmail.com>
To: "J.P. Lacerda" <jp.lacerda@codethink.co.uk>
Cc: akpm@linux-foundation.org, johan.wessfeldt@gmail.com,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] x86: Fix mcheck_init_device() to handle misc_register() correctly
Date: Fri, 4 Mar 2011 21:17:49 +0300 [thread overview]
Message-ID: <20110304181749.GA3469@bicker> (raw)
In-Reply-To: <1299245367-20279-1-git-send-email-jp.lacerda@codethink.co.uk>
On Fri, Mar 04, 2011 at 01:29:27PM +0000, J.P. Lacerda wrote:
> The return value for misc_register() was not being taken into account.
> Furthermore, if misc_register() fails, we must rollback any changes made by
> mcheck_init_device()
>
> Signed-off-by: J.P. Lacerda <jp.lacerda@codethink.co.uk>
Ah... You found a bug that Johan missed in his original patch. But you
still left out the case where mce_create_device() can fail which his
patch addressed. Also his patch was nicer; using gotos to unwind is
the standard way for kernel error handling.
Also why did you poach his patch without giving any kind of credit,
instead of just telling him about the bug??? WTF?
Johan, please fix add a free_cpumask_var(mce_dev_initialized); to your
patch. Call it [PATCH v2]. Add in the changelog that J.P. Lacerda
told you about the missing free_cpumask_var(mce_dev_initialized).
regards,
dan carpenter
next prev parent reply other threads:[~2011-03-04 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 13:29 [PATCH 1/1] x86: Fix mcheck_init_device() to handle misc_register() correctly J.P. Lacerda
2011-03-04 17:16 ` Borislav Petkov
2011-03-04 21:07 ` Johan Wessfeldt
2011-03-05 12:56 ` Borislav Petkov
2011-03-04 18:17 ` Dan Carpenter [this message]
2011-03-04 21:38 ` Johan Wessfeldt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304181749.GA3469@bicker \
--to=error27@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=johan.wessfeldt@gmail.com \
--cc=jp.lacerda@codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox