From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
containers@lists.linux-foundation.org,
jacob.jun.pan@linux.intel.com,
Arjan van de Ven <arjan@linux.intel.com>,
linux-kernel@vger.kernel.org, Matt Helsley <matthltc@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-api@vger.kernel.org
Subject: Re: [PATCH, v7] cgroups: introduce timer slack controller
Date: Sat, 5 Mar 2011 01:22:16 +0200 [thread overview]
Message-ID: <20110304232216.GA18343@shutemov.name> (raw)
In-Reply-To: <1299265422.22521.2.camel@laptop>
On Fri, Mar 04, 2011 at 08:03:42PM +0100, Peter Zijlstra wrote:
> On Wed, 2011-03-02 at 18:40 +0200, Kirill A. Shutsemov wrote:
> > - if (ret < current->timer_slack_ns)
> > - return current->timer_slack_ns;
> > - return ret;
> > + return clamp(__estimate_accuracy(&now),
> > + get_task_timer_slack(current), LONG_MAX);
>
> That actually makes the code worse, how about:
>
> min(__estimate_accuracy(), get_task_timer_slack()) ?
It's better. Thanks.
--
Kirill A. Shutemov
prev parent reply other threads:[~2011-03-04 23:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 16:40 [PATCH, v7] Introduce timer slack controller Kirill A. Shutsemov
2011-03-02 16:40 ` [PATCH, v7] cgroups: introduce " Kirill A. Shutsemov
2011-03-02 18:40 ` Thomas Gleixner
2011-03-03 6:59 ` Li Zefan
2011-03-03 7:34 ` Thomas Gleixner
2011-03-03 7:46 ` Matt Helsley
2011-03-03 8:28 ` Thomas Gleixner
2011-03-03 8:33 ` Kirill A. Shutemov
2011-03-04 19:03 ` Peter Zijlstra
2011-03-04 23:22 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304232216.GA18343@shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=containers@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=matthltc@us.ibm.com \
--cc=menage@google.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox