From: Dan Carpenter <error27@gmail.com>
To: wei_wang@realsil.com.cn
Cc: gregkh@suse.de, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts_pstor: MSXC card power class
Date: Mon, 7 Mar 2011 21:50:01 +0300 [thread overview]
Message-ID: <20110307185001.GX3416@bicker> (raw)
In-Reply-To: <1299485461-3941-1-git-send-email-wei_wang@realsil.com.cn>
On Mon, Mar 07, 2011 at 04:11:01PM +0800, wei_wang@realsil.com.cn wrote:
> #ifdef XC_POWERCLASS
> - u8 change_power_class = 2;
> + u8 change_power_class;
> +
> + if (chip->ms_power_class_en & 0x02) {
> + change_power_class = 2;
> + } else if (chip->ms_power_class_en & 0x01) {
> + change_power_class = 1;
> + } else {
> + change_power_class = 0;
> + }
This makes scripts/checkpatch.pl complain.
regards,
dan carpenter
next prev parent reply other threads:[~2011-03-07 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 8:11 [PATCH] staging: rts_pstor: MSXC card power class wei_wang
2011-03-07 18:50 ` Dan Carpenter [this message]
2011-03-08 2:40 ` wwang
2011-03-08 5:04 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2011-03-08 7:22 wei_wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307185001.GX3416@bicker \
--to=error27@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox