From: Dan Carpenter <error27@gmail.com>
To: Belisko Marek <marek.belisko@gmail.com>
Cc: Marek Belisko <marek.belisko@open-nandra.com>,
gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/21] staging: ft1000: Fix coding style in ft1000_usb_transmit_complete function.
Date: Mon, 7 Mar 2011 23:38:59 +0300 [thread overview]
Message-ID: <20110307203858.GY3416@bicker> (raw)
In-Reply-To: <AANLkTiknavmcagz63oFmqhgF5nV6xEMmLwU=i129LcVB@mail.gmail.com>
On Mon, Mar 07, 2011 at 08:25:07PM +0100, Belisko Marek wrote:
> On Mon, Mar 7, 2011 at 4:55 PM, Dan Carpenter <error27@gmail.com> wrote:
> > On Mon, Mar 07, 2011 at 09:21:16AM +0100, Marek Belisko wrote:
> >> - if (urb->status)
> >> - printk("%s: TX status %d\n", ft1000dev->net->name, urb->status);
> >> + if (urb->status)
> >> + DEBUG("%s: TX status %d\n", ft1000dev->net->name, urb->status);
> >>
> >
> > Why did you change the printk() to a DEBUG()? That's a behavior change,
> > and it should have been mentioned in the commit message.
> Mea culpa. checkpatch.pl complain about no KERN_... prefix so just fix with
> replace to DEBUG. Will return back to printk.
> @Greg: should resend whole serie or just this patch?
pr_err() or pr_info() would probably be better.
Here is how the usb-skeleton driver handles this btw:
/* sync/async unlink faults aren't errors */
if (urb->status) {
if (!(urb->status == -ENOENT ||
urb->status == -ECONNRESET ||
urb->status == -ESHUTDOWN))
err("%s - nonzero write bulk status received: %d",
__func__, urb->status);
dev->errors = urb->status;
} else {
dev->bulk_in_filled = urb->actual_length;
}
That uses the old usb err() macro which I think is not recomended these
days. Use pr_err() instead.
Do the other patches still apply if you resend just this patch? Btw
git send-email has a --in-reply-to option so that the V2 is attached to
the same thread as the original patch.
regards,
dan carpenter
next prev parent reply other threads:[~2011-03-07 20:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 8:21 [PATCH 00/21] Coding style and minor changes in ft1000_hw Marek Belisko
2011-03-07 8:21 ` [PATCH 01/21] staging: ft1000: Replace camelcase CardSendCommand function name Marek Belisko
2011-03-07 8:21 ` [PATCH 02/21] staging: ft1000: Fix coding style in card_send_command function Marek Belisko
2011-03-07 8:21 ` [PATCH 03/21] staging: ft1000: Fix coding style in dsp_reload function Marek Belisko
2011-03-07 8:21 ` [PATCH 04/21] staging: ft1000: Fix coding style in ft1000_reset_asic function Marek Belisko
2011-03-07 8:21 ` [PATCH 05/21] staging: ft1000: Fix coding style in ft1000_reset_card function Marek Belisko
2011-03-07 8:21 ` [PATCH 06/21] staging: ft1000: Fix identation in ftnet_ops struct Marek Belisko
2011-03-07 8:21 ` [PATCH 07/21] staging: ft1000: Fix coding style in init_ft1000_netdev function Marek Belisko
2011-03-07 8:21 ` [PATCH 08/21] staging: ft1000: Change return value for " Marek Belisko
2011-03-07 8:21 ` [PATCH 09/21] staging: ft1000: Fix coding style in reg_ft1000_netdev function Marek Belisko
2011-03-07 8:21 ` [PATCH 10/21] staging: ft1000: Fix coding style in ft1000_reset function Marek Belisko
2011-03-07 8:21 ` [PATCH 11/21] staging: ft1000: Fix coding style in ft1000_usb_transmit_complete function Marek Belisko
2011-03-07 15:55 ` Dan Carpenter
2011-03-07 19:25 ` Belisko Marek
2011-03-07 20:38 ` Dan Carpenter [this message]
2011-03-07 22:01 ` Greg KH
2011-03-08 11:34 ` [PATCH 11/21 v2] " Marek Belisko
2011-03-07 8:21 ` [PATCH 12/21] staging: ft1000: Fix coding style in ft1000_copy_down_pkt function Marek Belisko
2011-03-07 8:21 ` [PATCH 13/21] staging: ft1000: Fix coding style in ft1000_start_xmit function Marek Belisko
2011-03-07 8:21 ` [PATCH 14/21] staging: ft1000: Fix coding style in ft1000_submit_rx_urb function Marek Belisko
2011-03-08 11:33 ` [PATCH 14/21 v2] " Marek Belisko
2011-03-07 8:21 ` [PATCH 15/21] staging: ft1000: Fix coding style in ft1000_copy_up_pkt function Marek Belisko
2011-03-07 8:21 ` [PATCH 16/21] staging: ft1000: Fix coding style in ft1000_open function Marek Belisko
2011-03-07 8:21 ` [PATCH 17/21] staging: ft1000: Fix coding style in ft1000_close function Marek Belisko
2011-03-07 8:21 ` [PATCH 18/21] staging: ft1000: Fix coding style in ft1000_chkcard function Marek Belisko
2011-03-07 8:21 ` [PATCH 19/21] staging: ft1000: Fix coding style in ft1000_receive_cmd function Marek Belisko
2011-03-07 8:21 ` [PATCH 20/21] staging: ft1000: Fix coding style in ft1000_dsp_prov function Marek Belisko
2011-03-07 8:21 ` [PATCH 21/21] staging: ft1000: Fix coding style in ft1000_proc_drvmsg function Marek Belisko
2011-03-10 0:00 ` [PATCH 00/21] Coding style and minor changes in ft1000_hw Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307203858.GY3416@bicker \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=marek.belisko@open-nandra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox