[PATCH] [stable-37] ideapad: read brightness setting when have brightness key notify

[PATCH] [stable-37] ideapad: read brightness setting when have brightness key notify

[Ike Panhc]

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=25922

On ideapad Y530, the brightness key notify will be blocked if the last notify
is not responsed by getting the brightness value. Read value when we get the
notify shall fix the problem and will not have any difference on other ideapads.

This patch is made against 2.6.37.y and this bug impacts kernel after 2.6.37.

The equivalent-fix patch is not in upstream yet. Since the policy of stable tree
is changed and .38 kernel is going to finalize. I think to post this patch for
stable kernel now should be a good idea.

Signed-off-by: Ike Panhc <ike.pan@canonical.com>
---
 drivers/platform/x86/ideapad-laptop.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 5ff1220..e78398d 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -357,6 +357,8 @@ static void ideapad_acpi_notify(struct acpi_device *adevice, u32 event)
 		if (test_bit(vpc_bit, &vpc1)) {
 			if (vpc_bit == 9)
 				ideapad_sync_rfk_state(adevice);
+			else if (vpc_bit == 4)
+				read_ec_data(handle, 0x12, &vpc2);
 		}
 	}
 }
-- 
1.7.4.1

Re: [stable] [PATCH] [stable-37] ideapad: read brightness setting when have brightness key notify

[Greg KH]

On Mon, Mar 07, 2011 at 06:35:25PM +0800, Ike Panhc wrote:
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=25922
> 
> On ideapad Y530, the brightness key notify will be blocked if the last notify
> is not responsed by getting the brightness value. Read value when we get the
> notify shall fix the problem and will not have any difference on other ideapads.
> 
> This patch is made against 2.6.37.y and this bug impacts kernel after 2.6.37.
> 
> The equivalent-fix patch is not in upstream yet. Since the policy of stable tree
> is changed and .38 kernel is going to finalize.

What "policy of the stable tree is changed"?  Huh?

> I think to post this patch for stable kernel now should be a good
> idea.

Have you not read the Documentation/stable_kernel_rules.txt and seen
that this is totally and completly not allowed?  Why is it suddenly not
true?

confused,

greg k-h

Re: [stable] [PATCH] [stable-37] ideapad: read brightness setting when have brightness key notify

[Ike Panhc]

On 03/08/2011 12:18 AM, Greg KH wrote:
> On Mon, Mar 07, 2011 at 06:35:25PM +0800, Ike Panhc wrote:
>> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=25922
>>
>> On ideapad Y530, the brightness key notify will be blocked if the last notify
>> is not responsed by getting the brightness value. Read value when we get the
>> notify shall fix the problem and will not have any difference on other ideapads.
>>
>> This patch is made against 2.6.37.y and this bug impacts kernel after 2.6.37.
>>
>> The equivalent-fix patch is not in upstream yet. Since the policy of stable tree
>> is changed and .38 kernel is going to finalize.
> 
> What "policy of the stable tree is changed"?  Huh?

I thought we will have stable release on lastest kernel only[1]. Since the .38 is
going to release soon. It seems I do not have much time for .37 stable release.

I hope I do not miss something.

[1] https://lkml.org/lkml/2010/12/2/388

> 
>> I think to post this patch for stable kernel now should be a good
>> idea.
> 
> Have you not read the Documentation/stable_kernel_rules.txt and seen
> that this is totally and completly not allowed?  Why is it suddenly not
> true?
> 
> confused,

Sorry about the confusing. The same patch for upstream is posted[2] but not merged
yet. It looks like a now-or-never situation to me. That's why I post and write the
concerns in comment.

[1] https://lkml.org/lkml/2011/2/23/171

> 
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [stable] [PATCH] [stable-37] ideapad: read brightness setting when have brightness key notify

[Greg KH]

On Tue, Mar 08, 2011 at 10:37:41AM +0800, Ike Panhc wrote:
> On 03/08/2011 12:18 AM, Greg KH wrote:
> > On Mon, Mar 07, 2011 at 06:35:25PM +0800, Ike Panhc wrote:
> >> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=25922
> >>
> >> On ideapad Y530, the brightness key notify will be blocked if the last notify
> >> is not responsed by getting the brightness value. Read value when we get the
> >> notify shall fix the problem and will not have any difference on other ideapads.
> >>
> >> This patch is made against 2.6.37.y and this bug impacts kernel after 2.6.37.
> >>
> >> The equivalent-fix patch is not in upstream yet. Since the policy of stable tree
> >> is changed and .38 kernel is going to finalize.
> > 
> > What "policy of the stable tree is changed"?  Huh?
> 
> I thought we will have stable release on lastest kernel only[1]. Since the .38 is
> going to release soon. It seems I do not have much time for .37 stable release.
> 
> I hope I do not miss something.
> 
> [1] https://lkml.org/lkml/2010/12/2/388

I think you miss the fact that if by the time your patch makes it into
Linus's tree, and we have moved on to not supporting .37 anymore, then
no one will care about .37 so it doesn't matter at all.

> >> I think to post this patch for stable kernel now should be a good
> >> idea.
> > 
> > Have you not read the Documentation/stable_kernel_rules.txt and seen
> > that this is totally and completly not allowed?  Why is it suddenly not
> > true?
> > 
> > confused,
> 
> Sorry about the confusing. The same patch for upstream is posted[2] but not merged
> yet. It looks like a now-or-never situation to me. That's why I post and write the
> concerns in comment.

You need to follow the documented and well explained rules, they are
there for a very good reason, please don't try to subvert them,
otherwise you will just end up in my kill file.

thanks,

greg k-h