From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Ola Lilja <ola.o.lilja@stericsson.com>
Subject: Re: [PATCH 1/3] mfd: add a core driver for TI TPS61050/TPS61052 chips
Date: Tue, 8 Mar 2011 11:52:22 +0000 [thread overview]
Message-ID: <20110308115222.GB20944@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1299577241-31328-1-git-send-email-linus.walleij@stericsson.com>
On Tue, Mar 08, 2011 at 10:40:41AM +0100, Linus Walleij wrote:
> +config TPS6105X
> + tristate "TPS61050/61052 Boost Converters"
> + depends on I2C && EXPERIMENTAL
Why EXPERIMENTAL?
> + select REGULATOR
> + select REGULATOR_FIXED_VOLTAGE
> + default y if MACH_U8500
Not sure I'm enthusiastic about that - it's sensible for the machine to
want that but I can see this getting out of hand if you've got a lot of
machines doing that. Perhaps have the machine select the regulator for
builds with REGULATOR enabled?
> + /* Put the chip in SHUTDOWN mode */
> + ret = tps6105x_mask_and_set(tps6105x, TPS6105X_REG_0,
> + TPS6105X_REG0_MODE_MASK,
> + TPS6105X_REG0_MODE_SHUTDOWN << TPS6105X_REG0_MODE_SHIFT);
> + if (ret)
> + return ret;
I'm not sure this is what we want. If the device is driving the
backlight it'll result in the backlight flashing off during boot which
doesn't seem desirable. The standard thing is just to inherit the
hardware state.
next prev parent reply other threads:[~2011-03-08 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 9:40 [PATCH 1/3] mfd: add a core driver for TI TPS61050/TPS61052 chips Linus Walleij
2011-03-08 11:52 ` Mark Brown [this message]
2011-03-08 12:58 ` Linus Walleij
2011-03-18 1:05 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308115222.GB20944@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=ola.o.lilja@stericsson.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox