From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Samuel Ortiz <samuel.ortiz@intel.com>,
Ola Lilja <ola.o.lilja@stericsson.com>
Subject: Re: [PATCH 2/3] regulator: add a subdriver for TI TPS6105x regulator portions
Date: Tue, 8 Mar 2011 13:29:13 +0000 [thread overview]
Message-ID: <20110308132912.GC5892@sirena.org.uk> (raw)
In-Reply-To: <AANLkTin7qD7O70u5HQVgWXQZTFR1O8dUOqyKWmn6sU1b@mail.gmail.com>
On Tue, Mar 08, 2011 at 02:26:14PM +0100, Linus Walleij wrote:
> On Tue, Mar 8, 2011 at 12:56 PM, Mark Brown
> >> + ? ? /* This instance is not set for regulator mode so bail out */
> >> + ? ? if (pdata->mode != TPS6105X_MODE_VOLTAGE)
> >> + ? ? ? ? ? ? return 0;
> > -ENODEV? ?Logging to explain why we're bombing out might be helpful too.
> Not in this case actually, the chip is configured by platform data to
> operate as regulator, LED or flashgun. All three drivers may be
> compiled in at some point, and a system may have three TPS chips
> performing each function. They will spawn three children each,
> but only one of them should probe.
> So the fact that the regulator driver doesn't probe doesn't mean any
> failure, some other driver will likely probe successfully for the chip.
The general approach other MFDs have taken to this is to pay attention
to the platform data when registering subdevices so that you don't get
inappropriate subdevices registered in the first place.
next prev parent reply other threads:[~2011-03-08 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 9:42 [PATCH 2/3] regulator: add a subdriver for TI TPS6105x regulator portions Linus Walleij
2011-03-08 11:56 ` Mark Brown
2011-03-08 13:26 ` Linus Walleij
2011-03-08 13:29 ` Mark Brown [this message]
2011-03-08 13:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308132912.GC5892@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=ola.o.lilja@stericsson.com \
--cc=samuel.ortiz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox