From: Greg KH <greg@kroah.com>
To: Minkyu Kang <mk7.kang@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
kyungmin.park@samsung.com, Ben Dooks <ben-i2c@fluff.org>
Subject: Re: [PATCH v3] misc: adds support the FSA9480 USB Switch
Date: Tue, 8 Mar 2011 05:59:09 -0800 [thread overview]
Message-ID: <20110308135909.GA7519@kroah.com> (raw)
In-Reply-To: <4D75D338.9070801@samsung.com>
On Tue, Mar 08, 2011 at 03:56:56PM +0900, Minkyu Kang wrote:
> --- /dev/null
> +++ b/include/linux/fsa9480.h
Why do you need a .h file for this driver?
If it's just for platform data, please put it in
include/linux/platform_data/ instead.
If it's not, then please just move it to your driver's .c file.
thanks,
greg k-h
next prev parent reply other threads:[~2011-03-08 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 6:56 [PATCH v3] misc: adds support the FSA9480 USB Switch Minkyu Kang
2011-03-08 13:59 ` Greg KH [this message]
2011-03-08 23:59 ` Minkyu Kang
2011-03-09 0:09 ` Greg KH
2011-03-09 0:41 ` Minkyu Kang
2011-03-09 8:34 ` [PATCH v4] " Minkyu Kang
2011-06-29 10:14 ` [PATCH v5] " Donggeun Kim
2011-06-29 11:34 ` anish singh
2011-06-29 19:55 ` Andrew Morton
2011-03-08 21:02 ` [PATCH v3] " Dave Jones
2011-03-09 0:01 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308135909.GA7519@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=ben-i2c@fluff.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mk7.kang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox