From: Vivek Goyal <vgoyal@redhat.com>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Justin TerAvest <teravest@google.com>,
"ctalbott@google.com" <ctalbott@google.com>,
"guijianfeng@cn.fujitsu.com" <guijianfeng@cn.fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk-cgroup: Lower minimum weight from 100 to 10.
Date: Tue, 8 Mar 2011 10:03:57 -0500 [thread overview]
Message-ID: <20110308150357.GE27455@redhat.com> (raw)
In-Reply-To: <4D763F07.1070103@fusionio.com>
On Tue, Mar 08, 2011 at 03:36:55PM +0100, Jens Axboe wrote:
> On 2011-03-07 23:53, Justin TerAvest wrote:
> > We've found that we still get good, useful isolation at weights this
> > low. I'd like to adjust the minimum so that any other changes can take
> > these values into account.
>
> Justin, this looks fine to me if Vivek agrees. You did not sign-off on
> the patch though, so I can't apply it yet. Please re-send with the ack
> from Vivek added and your signed-off-by as well.
The primary reason I am fine with wider weight range because there are
many situations where we just don't get effective 10 times service
differentiation for various reasons like workload don't seem to be
active at the service tree at the same time or if we decide to swith
off idling on faster storage etc.
So because of this leaky nature of service differentiation, it might help to
have a wider range of allowed weights.
Thanks
Vivek
prev parent reply other threads:[~2011-03-08 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 22:53 [PATCH] blk-cgroup: Lower minimum weight from 100 to 10 Justin TerAvest
2011-03-08 14:31 ` Vivek Goyal
2011-03-08 14:36 ` Jens Axboe
2011-03-08 15:03 ` Vivek Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308150357.GE27455@redhat.com \
--to=vgoyal@redhat.com \
--cc=ctalbott@google.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=teravest@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox