From: Dan Carpenter <error27@gmail.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, arnaud.patard@rtp-net.org
Subject: Re: [PATCH 06/15] staging: xgifb: delete bIntegratedMMEnabled
Date: Wed, 9 Mar 2011 14:08:05 +0300 [thread overview]
Message-ID: <20110309110805.GE3416@bicker> (raw)
In-Reply-To: <alpine.DEB.1.10.1103091014430.12072@loser>
On Wed, Mar 09, 2011 at 10:23:01AM +0200, Aaro Koskinen wrote:
> Hi,
>
> On Wed, 9 Mar 2011, Dan Carpenter wrote:
> >On Tue, Mar 08, 2011 at 10:16:11PM +0200, Aaro Koskinen wrote:
> >>bIntegratedMMEnabled is always true, so the field and checks can be
> >>eliminated.
> >>
> >What about for the chips that came before the XG40? Are we dropping
> >support for them?
>
> They were never supported. See the earlier switch (xgi_video_info.chip_id)
> statement in the probe routine - it will return -ENODEV for other chips
> than XG40..XG27.
>
Ah... That's true. This patch is fine by me then.
Reviewed-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
next prev parent reply other threads:[~2011-03-09 11:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 20:16 [PATCH 00/15] staging: xgifb: misc cleanups Aaro Koskinen
2011-03-08 20:16 ` [PATCH 01/15] staging: xgifb: delete HW cursor memory allocation Aaro Koskinen
2011-03-08 20:16 ` [PATCH 02/15] staging: xgifb: delete command queue selection/init Aaro Koskinen
2011-03-08 20:16 ` [PATCH 03/15] staging: xgifb: delete offscreen memory management Aaro Koskinen
2011-03-08 20:16 ` [PATCH 04/15] staging: xgifb: delete unused fields from xgi_hw_device_info Aaro Koskinen
2011-03-08 20:16 ` [PATCH 05/15] staging: xgifb: delete bSkipSense Aaro Koskinen
2011-03-08 20:16 ` [PATCH 06/15] staging: xgifb: delete bIntegratedMMEnabled Aaro Koskinen
2011-03-08 22:36 ` Dan Carpenter
2011-03-09 8:23 ` Aaro Koskinen
2011-03-09 11:08 ` Dan Carpenter [this message]
2011-03-08 20:16 ` [PATCH 07/15] staging: xgifb: delete nomax module parameter Aaro Koskinen
2011-03-08 20:16 ` [PATCH 08/15] staging: xgifb: vb_setmode: make internal functions static Aaro Koskinen
2011-03-08 20:16 ` [PATCH 09/15] staging: xgifb: vb_setmode: include the .h file Aaro Koskinen
2011-03-08 20:16 ` [PATCH 10/15] staging: xgifb: vb_ext: delete redundant declarations Aaro Koskinen
2011-03-08 20:16 ` [PATCH 11/15] staging: xgifb: vb_ext: delete unused functions Aaro Koskinen
2011-03-08 20:16 ` [PATCH 12/15] staging: xgifb: vb_ext: make internal functions static Aaro Koskinen
2011-03-08 20:16 ` [PATCH 13/15] staging: xgifb: vb_init: delete redundant declarations Aaro Koskinen
2011-03-08 20:16 ` [PATCH 14/15] staging: xgifb: vb_init: delete unused functions Aaro Koskinen
2011-03-08 20:16 ` [PATCH 15/15] staging: xgifb: vb_init: make internal functions static Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309110805.GE3416@bicker \
--to=error27@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=arnaud.patard@rtp-net.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox