From: scameron@beardog.cce.hp.com
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: james.bottomley@hansenpartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
smcameron@yahoo.com, thenzl@redhat.com,
akpm@linux-foundation.org, mikem@beardog.cce.hp.com
Subject: Re: [PATCH 2/2] hpsa: export resettable_on_kexec host attribute
Date: Wed, 9 Mar 2011 08:36:09 -0600 [thread overview]
Message-ID: <20110309143609.GG12760@beardog.cce.hp.com> (raw)
In-Reply-To: <20110309063339.GB16951@cr0.redhat.com>
On Wed, Mar 09, 2011 at 02:33:39PM +0800, Américo Wang wrote:
> On Tue, Mar 08, 2011 at 05:10:03PM -0600, Stephen M. Cameron wrote:
> >From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> >
> >This attribute, requested by Redhat, allows kexec-tools to know
> >whether the controller can honor the reset_devices kernel parameter
> >and actually reset the controller. For kdump to work properly it
> >is necessary that the reset_devices parameter be honored. This
> >attribute enables kexec-tools to warn the user if they attempt to
> >designate a non-resettable controller as the dump device.
> >
> >Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> Maybe we should docment this sysfs attribute somewhere?
Yes, thanks.
Perhaps in Documentation/ABI/testing/sysfs-bus-scsi-devices-hpsa
(which doesn't exist) and/or in Documentation/scsi/hpsa.txt (which does exist, and
is where other hpsa specific sysfs attributes are documented.) Probably so
as not to duplicate things, the latter. Or maybe what documentation of
sysfs things that is currently in hpsa.txt should be moved to Documentation/ABI/...
and a reference to it put in hpsa.txt?
-- steve
next prev parent reply other threads:[~2011-03-09 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 23:09 [PATCH 0/2] hpsa: add sysfs host attribute to indicate whether reset_devices is honored Stephen M. Cameron
2011-03-08 23:09 ` [PATCH 1/2] hpsa: move device attributes to avoid forward declarations Stephen M. Cameron
2011-03-08 23:10 ` [PATCH 2/2] hpsa: export resettable_on_kexec host attribute Stephen M. Cameron
2011-03-09 6:33 ` Américo Wang
2011-03-09 14:36 ` scameron [this message]
2011-03-09 12:27 ` Tomas Henzl
2011-03-09 14:27 ` scameron
2011-03-09 15:14 ` scameron
2011-03-09 15:33 ` Tomas Henzl
2011-03-09 14:36 ` Vivek Goyal
2011-03-09 14:51 ` scameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309143609.GG12760@beardog.cce.hp.com \
--to=scameron@beardog.cce.hp.com \
--cc=akpm@linux-foundation.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikem@beardog.cce.hp.com \
--cc=smcameron@yahoo.com \
--cc=thenzl@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox