From: Ingo Molnar <mingo@elte.hu>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: sedat.dilek@gmail.com, Sedat Dilek <sedat.dilek@googlemail.com>,
Alexander van Heukelum <heukelum@fastmail.fm>,
linux-next <linux-next@vger.kernel.org>,
psomas@cslab.ece.ntua.gr, Jan Beulich <JBeulich@novell.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: linux-next: Tree for March 8 (BROKEN: arch/x86/kernel/entry_32.S? Debian's binutils/as?)
Date: Wed, 9 Mar 2011 17:02:41 +0100 [thread overview]
Message-ID: <20110309160241.GC31249@elte.hu> (raw)
In-Reply-To: <AANLkTiks9o18LRS46CrYHBXzq_6U-v-CqK=0Fzc4Tuco@mail.gmail.com>
* H.J. Lu <hjl.tools@gmail.com> wrote:
> > Yes, the .size directive not matching up is technically a bug, but it was not
> > checked by binutils before, for *years* - and you cannot just flip a switch and
> > break who knows how much code.
> >
> > You need to at least emit a warning for some time to give people a *chance* to
> > fix bugs - not just stuff an incompatible binutils down their throat and break
> > the kernel build for thousands of commits and break bisection.
>
> If kernel doesn't use/need symbol size, don't put it in assembly code.
What does that have to do with the question i raised: that of binutils backwards
(in)compatibility to be able to build the Linux kernel?
> > This binutils change is breaking numerous upstream kernel builds (and is making
> > bisection with new binutils impossible) for no particular good reason: binutils
> > was capable to figure out the symbol name before this change.
>
> That is totally false. The old assembler just generates incorrect size and It
> couldn't read the programmer's mind to find the correct symbol name.
Still it didnt make the kernel not build and it did not make the kernel not boot. It
at most confused some ELF symbol table - which the kernel does not need.
So all i'm trying to point out to you is that you appear to be seeing the world in a
very binary way: 'broken' versus 'correct' and that it can be rather harmful if you
project that binary view on the real world that in reality is not binary but is
shades of grey.
You are turning a benign ELF symbol table detail (that does not affect the kernel's
ability to boot/work) into a hard build breakage and bisection barrier, covering
hundreds of commits.
I'm not denying that it's buggy code - I'm just asking you to *PLEASE* at minimum
acknowledge that surprise flag days that turn a before-benign condition into a fatal
build failure suck to everyone else outside your own little universe.
Thanks,
Ingo
next prev parent reply other threads:[~2011-03-09 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 10:44 linux-next: Tree for March 8 (BROKEN: arch/x86/kernel/entry_32.S? Debian's binutils/as?) Sedat Dilek
2011-03-08 12:44 ` Sedat Dilek
2011-03-08 14:55 ` H.J. Lu
2011-03-08 15:28 ` Sedat Dilek
2011-03-08 15:42 ` Sedat Dilek
[not found] ` <1299605269.29313.1427511237@webmail.messagingengine.com>
[not found] ` <AANLkTi=6YstJxad41knR4Q9WN3wYKikPv-g1i3kg3HS1@mail.gmail.com>
[not found] ` <1299615939.25628.1427572905@webmail.messagingengine.com>
[not found] ` <AANLkTimBMP1jiuEEUwmKKVNZcZnrkFxFA_YBcLmkEFJM@mail.gmail.com>
[not found] ` <AANLkTikpMAXfG5aNWo8x7pKKppaQiE-U8qjFaG0B2azV@mail.gmail.com>
2011-03-09 8:51 ` Ingo Molnar
2011-03-09 10:16 ` Sedat Dilek
2011-03-09 11:51 ` Ingo Molnar
2011-03-09 15:40 ` H.J. Lu
2011-03-09 16:02 ` Ingo Molnar [this message]
2011-03-09 19:04 ` H.J. Lu
2011-03-10 7:17 ` Ingo Molnar
2011-03-10 15:54 ` H.J. Lu
2011-03-12 8:25 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309160241.GC31249@elte.hu \
--to=mingo@elte.hu \
--cc=JBeulich@novell.com \
--cc=akpm@linux-foundation.org \
--cc=heukelum@fastmail.fm \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=psomas@cslab.ece.ntua.gr \
--cc=sedat.dilek@gmail.com \
--cc=sedat.dilek@googlemail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox