Re: [PATCH 07/10] perf script: Move printing of 'common' data from print_event and rename

[Frederic Weisbecker <fweisbec@gmail.com>]

On Wed, Mar 09, 2011 at 05:11:55PM -0700, David Ahern wrote:
> 
> 
> On 03/09/11 17:10, Frederic Weisbecker wrote:
> > On Wed, Mar 09, 2011 at 05:04:31PM -0700, David Ahern wrote:
> >>
> >>
> >> On 03/09/11 16:50, Frederic Weisbecker wrote:
> >>
> >>>> +++ b/tools/perf/util/trace-event-parse.c
> >>>> @@ -2648,63 +2648,8 @@ static void print_lat_fmt(void *data, int size __unused)
> >>>>  		printf("%d", lock_depth);
> >>>>  }
> >>>>  
> >>>> -/* taken from Linux, written by Frederic Weisbecker */
> >>>> -static void print_graph_cpu(int cpu)
> >>>> -{
> >>>> -	int i;
> >>>> -	int log10_this = log10_cpu(cpu);
> >>>> -	int log10_all = log10_cpu(cpus);
> >>>> -
> >>>> -
> >>>> -	/*
> >>>> -	 * Start with a space character - to make it stand out
> >>>> -	 * to the right a bit when trace output is pasted into
> >>>> -	 * email:
> >>>> -	 */
> >>>> -	printf(" ");
> >>>> -
> >>>> -	/*
> >>>> -	 * Tricky - we space the CPU field according to the max
> >>>> -	 * number of online CPUs. On a 2-cpu system it would take
> >>>> -	 * a maximum of 1 digit - on a 128 cpu system it would
> >>>> -	 * take up to 3 digits:
> >>>> -	 */
> >>>> -	for (i = 0; i < log10_all - log10_this; i++)
> >>>> -		printf(" ");
> >>>> -
> >>>> -	printf("%d) ", cpu);
> >>>> -}
> >>>
> >>> So, we indeed don't use the function graph tracer with perf yet.
> >>> But there are fair chances we will in the future.
> >>>
> >>> So if we remove such code, I would prefer this to be made as
> >>> a seperate commit. Something we can easily retrieve and revert
> >>> in the future.
> >>
> >> Once the references to the functions are removed, compile fails --
> >> functions defined without a user.
> >>
> >> I left the cpu arg into print_trace_event to avoid having to delete even
> >> more code because of that.
> > 
> > And if you actually keep those functions in place?
> 
> Compile fails.

Ok, but why does it fail? :)

You can probably keep their callsites, like before they simply won't happen.