linux-next: build failure lin Linus' tree

linux-next: build failure lin Linus' tree

[Stephen Rothwell]

Hi Linus,

After merging the spi-current tree, today's linux-next build (x86_64
allmodconfig) failed like this:

include/linux/sysctl.h:28: included file 'linux/rcupdate.h' is not exported

Caused by commit dfef6dcd35cb ("unf*ck proc_sysctl ->d_compare()").

I applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 10 Mar 2011 11:14:17 +1100
Subject: [PATCH] sysctl: the include of rcupdate.h is only needed in the kernel

Fixes this built error:

include/linux/sysctl.h:28: included file 'linux/rcupdate.h' is not exported

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/sysctl.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
index bb7c2b0..11684d9 100644
--- a/include/linux/sysctl.h
+++ b/include/linux/sysctl.h
@@ -25,7 +25,6 @@
 #include <linux/kernel.h>
 #include <linux/types.h>
 #include <linux/compiler.h>
-#include <linux/rcupdate.h>
 
 struct completion;
 
@@ -931,6 +930,7 @@ enum
 
 #ifdef __KERNEL__
 #include <linux/list.h>
+#include <linux/rcupdate.h>
 
 /* For the /proc/sys support */
 struct ctl_table;
-- 
1.7.4.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure lin Linus' tree

[Al Viro]

On Thu, Mar 10, 2011 at 11:25:43AM +1100, Stephen Rothwell wrote:
> Hi Linus,
> 
> After merging the spi-current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> include/linux/sysctl.h:28: included file 'linux/rcupdate.h' is not exported
> 
> Caused by commit dfef6dcd35cb ("unf*ck proc_sysctl ->d_compare()").
> 
> I applied this patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 10 Mar 2011 11:14:17 +1100
> Subject: [PATCH] sysctl: the include of rcupdate.h is only needed in the kernel
> 
> Fixes this built error:
> 
> include/linux/sysctl.h:28: included file 'linux/rcupdate.h' is not exported
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

ACKed-by: Al Viro <viro@zeniv.linux.org.uk>