From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
Jeremy Fitzhardinge <jeremy@goop.org>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH 12/14] xen: events: remove use of nr_irqs as upper bound on number of pirqs
Date: Thu, 10 Mar 2011 00:33:05 -0500 [thread overview]
Message-ID: <20110310053305.GD10574@dumpdata.com> (raw)
In-Reply-To: <1299692486-28634-12-git-send-email-ian.campbell@citrix.com>
> int xen_irq_from_pirq(unsigned pirq)
> {
> - return pirq_to_irq[pirq];
> + int irq;
> +
> + struct irq_info *info;
> +
> + spin_lock(&irq_mapping_update_lock);
> +
> + list_for_each_entry(info, &xen_irq_list_head, list) {
> + if (info == NULL || info->type != IRQT_PIRQ)
> + continue;
> + irq = info->irq;
> + if (info->u.pirq.pirq == pirq)
> + goto out;
> + }
> + irq = -1;
> +out:
> + spin_lock(&irq_mapping_update_lock);
> +
> + return -1;
Shouldn't this be:
return irq
?
How come you are using the spin_lock here, but not
in other places when iterating over the xen_irq_list_head?
next prev parent reply other threads:[~2011-03-10 5:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 17:40 [GIT PATCH 0/14] xen: events: cleanups + ween off nr_irqs Ian Campbell
2011-03-09 17:41 ` [PATCH 01/14] xen: events: separate two unrelated halves of if condition Ian Campbell
2011-03-09 17:41 ` [PATCH 02/14] xen: events: fix xen_map_pirq_gsi error return Ian Campbell
2011-03-09 17:41 ` [PATCH 03/14] xen: events: simplify comment Ian Campbell
2011-03-09 17:41 ` [PATCH 04/14] xen: events: remove unused public functions Ian Campbell
2011-03-09 17:41 ` [PATCH 05/14] xen: events: rename restore_cpu_pirqs -> restore_pirqs Ian Campbell
2011-03-09 17:41 ` [PATCH 06/14] xen: events: refactor GSI pirq bindings functions Ian Campbell
2011-03-10 4:00 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-03-10 8:37 ` Ian Campbell
2011-03-09 17:41 ` [PATCH 07/14] xen: events: use per-cpu variable for cpu_evtchn_mask Ian Campbell
2011-03-09 17:41 ` [PATCH 08/14] xen: events: turn irq_info constructors into initialiser functions Ian Campbell
2011-03-09 17:41 ` [PATCH 09/14] xen: events: push setup of irq<->{evtchn,ipi,virq,pirq} maps into irq_info init functions Ian Campbell
2011-03-10 4:56 ` Konrad Rzeszutek Wilk
2011-03-10 8:42 ` Ian Campbell
2011-03-09 17:41 ` [PATCH 10/14] xen: events: maintain a list of Xen interrupts Ian Campbell
2011-03-10 5:22 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-03-10 8:43 ` Ian Campbell
2011-03-09 17:41 ` [PATCH 11/14] xen: events: dynamically allocate irq info structures Ian Campbell
2011-03-10 5:27 ` Konrad Rzeszutek Wilk
2011-03-10 8:51 ` Ian Campbell
2011-03-09 17:41 ` [PATCH 12/14] xen: events: remove use of nr_irqs as upper bound on number of pirqs Ian Campbell
2011-03-10 5:33 ` Konrad Rzeszutek Wilk [this message]
2011-03-10 8:57 ` Ian Campbell
2011-03-09 17:41 ` [PATCH 13/14] xen: events: do not workaround too-small nr_irqs Ian Campbell
2011-03-10 5:40 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-03-10 9:02 ` Ian Campbell
2011-03-09 17:41 ` [PATCH 14/14] xen: events: propagate irq allocation failure instead of panicking Ian Campbell
2011-03-10 5:38 ` Konrad Rzeszutek Wilk
2011-03-10 8:58 ` Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2011-03-10 16:07 [GIT PATCH v2 0/14] xen: events: cleanups + ween off nr_irqs Ian Campbell
2011-03-10 16:08 ` [PATCH 12/14] xen: events: remove use of nr_irqs as upper bound on number of pirqs Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310053305.GD10574@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox