Re: [PATCH 0/2] jump label: update for .39

[Jason Baron <jbaron@redhat.com>]

On Wed, Mar 09, 2011 at 10:36:31PM -0500, Steven Rostedt wrote:
> > Hi,
> > 
> > Re-fresh of updates against latest -tip tree.
> 
> Thanks Jason,
> 
> I started looking at them, I should have comments tomorrow (if I have
> any comments ;)
> 
> > 
> > I've tried to split this update up somewhat, but I've only succeeded to split
> > out the dynamic debug bits. The interface changes and re-write are quite
> > intertwined.
> > 
> > I believe this update should address all the comments from the previous posting
> > except for Mathieu's request for a section of jump label pointers that point to
> > the jump label structures (since the compiler might leave gaps in the jump label
> > structures).
> 
> The jump label structures is a list of 3 pointers, correct? I doubt that
> gcc would place any holes in it as they are all aligned by natural word
> size.
> 

yes:

<address to patch>
<address to jump to (when enabled)>
<key value (which is a pointer address)>

> >  I've got a prototype patch to address this issue but its somewhat
> > invasive, and thus I'd like to leave it as a follow-up item. I have to date,
> > not seen this issue in practice.
> > 
> > thanks,
> > 
> > -Jason
> > 
> > 
> > Jason Baron (2):
> >   jump label: introduce static_branch() interface
> >   dynamic debug: add jump label support
> > 
> >  arch/mips/include/asm/jump_label.h  |   22 +-
> >  arch/mips/kernel/jump_label.c       |    2 +-
> 
> Could we get Ralf's acked-by for the mips code.
> 
> >  arch/sparc/include/asm/jump_label.h |   25 +-
> 
> Could we get David Miller's Acked-by for sparc.
> 
> Thanks,
> 
> -- Steve
> 

Ok, I'll ping them.

thanks,

-Jason