From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: David Ahern <daahern@cisco.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
mingo@elte.hu, peterz@infradead.org, fweisbec@gmail.com,
paulus@samba.org, tglx@linutronix.de
Subject: Re: [PATCH 3/6] perf script: move printing of 'common' data from print_event and rename
Date: Thu, 10 Mar 2011 12:51:09 -0300 [thread overview]
Message-ID: <20110310155109.GB23555@ghostprotocols.net> (raw)
In-Reply-To: <20110310152053.GB12521@home.goodmis.org>
Em Thu, Mar 10, 2011 at 10:20:53AM -0500, Steven Rostedt escreveu:
> On Wed, Mar 09, 2011 at 10:23:25PM -0700, David Ahern wrote:
> > This change does impact output: latency data is trace specific and is now
> > printed after the common data - comm, tid, cpu, time and event name.
> > Signed-off-by: David Ahern <daahern@cisco.com>
> > tools/perf/builtin-script.c | 38 ++++++++++++++++++++++-----
> > tools/perf/util/trace-event-parse.c | 49 +++++++---------------------------
> I was hoping after the next merge window to start making a common library
> for parsing events. This way things like powertop and timechart or
> anything that uses the perf interface does not need to write its own
> parsing of events, or expect the event formats to be hardcoded.
>
> The trace-event-parse.c was taking from trace-cmd's parse-events.c code
> and hopefully the two can merge again. The parse-events.c code in
> trace-cmd has gone through several iterations that has made it much more
> robust and flexible. I purposely kept it as a separate libarary not
> dependent on trace-cmd so that it could be used by other utilities like
> perf.
David is kinda new to this perf/ftrace/trace-cmd/etc soap opera, and he
has been patient to go thru the motions with Peter, Thomas, Frédéric and
me, going from doing what he wants in 'perf report' to 'perf script',
etc.
We're almost to the point where his feature is implemented in a
way Frédéric, the one most actively reviewing his work, is satisfied,
right Frédéric?
I think the merge with the libraries you mention is something that is
not a precondition to merging David's work.
And his work is at least moving things in the trace parts of tools/,
that was so far dormant.
- Arnaldo
next prev parent reply other threads:[~2011-03-10 15:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 5:23 [PATCH 0/6 v4] perf script: add support for dumping events other than trace David Ahern
2011-03-10 5:23 ` [PATCH 1/6] perf script: change process_event prototype David Ahern
2011-03-16 13:53 ` [tip:perf/urgent] perf script: Change " tip-bot for David Ahern
2011-03-10 5:23 ` [PATCH 2/6] perf: remove print_graph_cpu and print_graph_proc from trace-event-parse David Ahern
2011-03-16 13:54 ` [tip:perf/urgent] perf tracing: Remove " tip-bot for David Ahern
2011-03-10 5:23 ` [PATCH 3/6] perf script: move printing of 'common' data from print_event and rename David Ahern
2011-03-10 15:20 ` Steven Rostedt
2011-03-10 15:51 ` Arnaldo Carvalho de Melo [this message]
2011-03-10 16:05 ` Steven Rostedt
2011-03-10 16:20 ` Arnaldo Carvalho de Melo
2011-03-10 16:45 ` David Ahern
2011-03-10 17:07 ` Steven Rostedt
2011-03-11 0:28 ` Frederic Weisbecker
2011-03-16 13:54 ` [tip:perf/urgent] perf script: Move " tip-bot for David Ahern
2011-03-10 5:23 ` [PATCH 4/6] perf script: support custom field selection for output David Ahern
2011-03-16 13:54 ` [tip:perf/urgent] perf script: Support " tip-bot for David Ahern
2011-03-10 5:23 ` [PATCH 5/6] perf script: add support for dumping symbols David Ahern
2011-03-16 13:55 ` [tip:perf/urgent] perf script: Add " tip-bot for David Ahern
2011-03-10 5:23 ` [PATCH 6/6] perf script: add support for H/W and S/W events David Ahern
2011-03-16 13:55 ` [tip:perf/urgent] perf script: Add " tip-bot for David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310155109.GB23555@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=daahern@cisco.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox