Re: [PATCH 3/6] perf script: move printing of 'common' data from print_event and rename

Arnaldo Carvalho de Melo
2011-03-10T16:20:47Z

Em Thu, Mar 10, 2011 at 11:05:35AM -0500, Steven Rostedt escreveu:
> On Thu, 2011-03-10 at 12:51 -0300, Arnaldo Carvalho de Melo wrote:
> > David is kinda new to this perf/ftrace/trace-cmd/etc soap opera, and he

> Lucky him ;)

:-)

> > has been patient to go thru the motions with Peter, Thomas, Frédéric and
> > me, going from doing what he wants in 'perf report' to 'perf script',
> > etc.
> >
> > We're almost to the point where his feature is implemented in a
> > way Frédéric, the one most actively reviewing his work, is satisfied,
> > right Frédéric?
>
> You must have one of those keyboards where it is easy to make that é

gnome makes this all mostly easy, and my native language, as Frédéric's,
have those pesky characters :)

> > I think the merge with the libraries you mention is something that is
> > not a precondition to merging David's work.
> >
> > And his work is at least moving things in the trace parts of tools/,
> > that was so far dormant.
>
> Note, I'm not saying that his work should be put on hold. I actually
> want to start it up again. Maybe I worded this response wrong. It was
> more about bringing David up to speed on what I want to do next than
> saying not to do this work.

Right, I just wanted to make sure he doesn't spill his coffee with what
could seem like yet another requirement to work on infrastructure to get
his legitimate feature implementation merged :-)

- Arnaldo