Re: [PATCH 3/6] perf script: move printing of 'common' data from print_event and rename

Frederic Weisbecker
2011-03-11T00:28:24Z

On Thu, Mar 10, 2011 at 12:51:09PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Mar 10, 2011 at 10:20:53AM -0500, Steven Rostedt escreveu:
> > On Wed, Mar 09, 2011 at 10:23:25PM -0700, David Ahern wrote:
> > > This change does impact output: latency data is trace specific and is now
> > > printed after the common data - comm, tid, cpu, time and event name.
>
> > > Signed-off-by: David Ahern <daahern@cisco.com>
>
> > > tools/perf/builtin-script.c | 38 ++++++++++++++++++++++-----
> > > tools/perf/util/trace-event-parse.c | 49 +++++++---------------------------
>
> > I was hoping after the next merge window to start making a common library
> > for parsing events. This way things like powertop and timechart or
> > anything that uses the perf interface does not need to write its own
> > parsing of events, or expect the event formats to be hardcoded.
> >
> > The trace-event-parse.c was taking from trace-cmd's parse-events.c code
> > and hopefully the two can merge again. The parse-events.c code in
> > trace-cmd has gone through several iterations that has made it much more
> > robust and flexible. I purposely kept it as a separate libarary not
> > dependent on trace-cmd so that it could be used by other utilities like
> > perf.
>
> David is kinda new to this perf/ftrace/trace-cmd/etc soap opera, and he
> has been patient to go thru the motions with Peter, Thomas, Frédéric and
> me, going from doing what he wants in 'perf report' to 'perf script',
> etc.
>
> We're almost to the point where his feature is implemented in a
> way Frédéric, the one most actively reviewing his work, is satisfied,
> right Frédéric?

Yeah, nice work! Thanks David!

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>