* [PATCH] Product ID for Logitech Driving Force Pro wheel
@ 2011-03-10 20:53 Michal Malý
2011-03-14 12:12 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Michal Malý @ 2011-03-10 20:53 UTC (permalink / raw)
To: linux-kernel; +Cc: jkosina
[-- Attachment #1: Type: Text/Plain, Size: 158 bytes --]
This trivial fix adds correct product ID for Logitech Driving Force Pro wheel
when it operates in native mode. This is needed to get force feedback working.
[-- Attachment #2: dfp_id_0.patch --]
[-- Type: text/x-patch, Size: 738 bytes --]
--- linux.orig/drivers/hid/hid-core.c 2011-03-08 06:09:37.000000000 +0100
+++ linux/drivers/hid/hid-core.c 2011-03-09 20:09:36.926973002 +0100
@@ -1368,6 +1368,7 @@
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOMO_WHEEL) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOMO_WHEEL2) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WII_WHEEL) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_RUMBLEPAD2) },
[-- Attachment #3: dfp_id_1.patch --]
[-- Type: text/x-patch, Size: 581 bytes --]
--- linux.orig/drivers/hid/hid-lg.c 2011-03-08 06:09:37.000000000 +0100
+++ linux/drivers/hid/hid-lg.c 2011-03-09 20:09:36.927973002 +0100
@@ -375,6 +375,8 @@
.driver_data = LG_FF },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOMO_WHEEL2),
.driver_data = LG_FF },
+ { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL),
+ .driver_data = LG_FF },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL),
.driver_data = LG_FF },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WII_WHEEL),
[-- Attachment #4: dfp_id_2.patch --]
[-- Type: text/x-patch, Size: 503 bytes --]
--- linux.orig/drivers/hid/hid-ids.h 2011-03-08 06:09:37.000000000 +0100
+++ linux/drivers/hid/hid-ids.h 2011-03-09 20:09:36.923973002 +0100
@@ -383,6 +383,7 @@
#define USB_DEVICE_ID_LOGITECH_WHEEL 0xc294
#define USB_DEVICE_ID_LOGITECH_WINGMAN_FFG 0xc293
#define USB_DEVICE_ID_LOGITECH_MOMO_WHEEL 0xc295
+#define USB_DEVICE_ID_LOGITECH_DFP_WHEEL 0xc298
#define USB_DEVICE_ID_LOGITECH_G25_WHEEL 0xc299
#define USB_DEVICE_ID_LOGITECH_WII_WHEEL 0xc29c
#define USB_DEVICE_ID_LOGITECH_ELITE_KBD 0xc30a
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Product ID for Logitech Driving Force Pro wheel
2011-03-10 20:53 [PATCH] Product ID for Logitech Driving Force Pro wheel Michal Malý
@ 2011-03-14 12:12 ` Jiri Kosina
2011-03-16 23:46 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2011-03-14 12:12 UTC (permalink / raw)
To: Michal Malý; +Cc: linux-kernel
On Thu, 10 Mar 2011, Michal Malý wrote:
> This trivial fix adds correct product ID for Logitech Driving Force Pro wheel
> when it operates in native mode. This is needed to get force feedback working.
Hi Michal,
could you please fixup and re-post your patch, according to
Documentation/SubmittingPatches?
Namely
- please add your Signed-off-by: line
- please send a patch in 'condensed' form, i.e. we don't want separate
diffs for separate files
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Product ID for Logitech Driving Force Pro wheel
2011-03-14 12:12 ` Jiri Kosina
@ 2011-03-16 23:46 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2011-03-16 23:46 UTC (permalink / raw)
To: Michal Malý; +Cc: linux-kernel
On Mon, 14 Mar 2011, Jiri Kosina wrote:
> > This trivial fix adds correct product ID for Logitech Driving Force Pro wheel
> > when it operates in native mode. This is needed to get force feedback working.
>
> Hi Michal,
>
> could you please fixup and re-post your patch, according to
> Documentation/SubmittingPatches?
>
> Namely
>
> - please add your Signed-off-by: line
> - please send a patch in 'condensed' form, i.e. we don't want separate
> diffs for separate files
As there has been no response, I have applied the patch below to my tree.
Thanks a lot for your report!
>From 5623a24a80814fe471e777f12b9dbbb0f77e002e Mon Sep 17 00:00:00 2001
From: Jiri Kosina <jkosina@suse.cz>
Date: Thu, 17 Mar 2011 00:43:23 +0100
Subject: [PATCH] HID: add support for Logitech Driving Force Pro wheel
Add force feedback support for Logitech Driving Force Pro wheel.
Device IDs reported by Michal Malý.
Reported-by: Michal Malý <madcatxster@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-lg.c | 2 ++
3 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 295e248..f99413b 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1368,6 +1368,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOMO_WHEEL) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOMO_WHEEL2) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WII_WHEEL) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_RUMBLEPAD2) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5f5cc91..cb21c41 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -383,6 +383,7 @@
#define USB_DEVICE_ID_LOGITECH_WHEEL 0xc294
#define USB_DEVICE_ID_LOGITECH_WINGMAN_FFG 0xc293
#define USB_DEVICE_ID_LOGITECH_MOMO_WHEEL 0xc295
+#define USB_DEVICE_ID_LOGITECH_DFP_WHEEL 0xc298
#define USB_DEVICE_ID_LOGITECH_G25_WHEEL 0xc299
#define USB_DEVICE_ID_LOGITECH_WII_WHEEL 0xc29c
#define USB_DEVICE_ID_LOGITECH_ELITE_KBD 0xc30a
diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
index aef4104..3da9040 100644
--- a/drivers/hid/hid-lg.c
+++ b/drivers/hid/hid-lg.c
@@ -377,6 +377,8 @@ static const struct hid_device_id lg_devices[] = {
.driver_data = LG_FF },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL),
.driver_data = LG_FF },
+ { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL),
+ .driver_data = LG_FF },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WII_WHEEL),
.driver_data = LG_FF4 },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WINGMAN_FFG ),
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-16 23:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-10 20:53 [PATCH] Product ID for Logitech Driving Force Pro wheel Michal Malý
2011-03-14 12:12 ` Jiri Kosina
2011-03-16 23:46 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox