From: Arnd Bergmann <arnd@arndb.de>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tty: serial: Fix build on architecture that does not have ioport
Date: Fri, 11 Mar 2011 08:58:29 +0100 [thread overview]
Message-ID: <201103110858.29140.arnd@arndb.de> (raw)
In-Reply-To: <1299822897-7047-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
On Friday 11 March 2011 06:54:56 Nobuhiro Iwamatsu wrote:
> Some CPU's do not have ioport. Therefore, these do not have inX/outX.
> Because they define CONFIG_NO_IOPORT, These CPU's use this and do not
> use inX/outX.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
I like this patch, I had played with something similar before
but never got it to the state where I was happy with submitting
it. I'd really like to get us to the point where platforms without
PCI support do don't need to define inb/outb and can still
use all other drivers.
There are two small improvements that I would like to suggest
to this patch:
* use #ifdef CONFIG_SERIAL_8250_HUB6 to configure out hub6 support.
It's already disabled on most systems, so we can save a bit
binary code without making the driver uglier.
* Introduce a new CONFIG_SERIAL_8250_IOPORT symbol and make
the normal io_serial_* code depend on that. It can be a silent
Kconfig symbol that automatically gets selected in the appropriate
cases. I find this clearer than the double negation in "not no ioport".
The code that is used in both HUB6 and regular cases can be under
this symbol.
Arnd
next prev parent reply other threads:[~2011-03-11 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 5:54 [PATCH 1/2] tty: serial: Fix build on architecture that does not have ioport Nobuhiro Iwamatsu
2011-03-11 5:54 ` [PATCH 2/2] tty: serial: Check UPF_FOURPORT, when CONFIG_SERIAL_8250_FOURPORT is defined Nobuhiro Iwamatsu
2011-03-11 8:04 ` Arnd Bergmann
2011-03-11 7:58 ` Arnd Bergmann [this message]
2011-03-11 12:57 ` [PATCH 1/2] tty: serial: Fix build on architecture that does not have ioport Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103110858.29140.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox