Re: [PATCH 2/3] ptp: add a software clock based on clock_monotonic_raw

john stultz
2011-03-03T19:34:27Z

On Thu, 2011-03-03 at 18:26 +0100, Torben Hohn wrote:
> First version of a software clock. Not very useful yet,
> as it doesnt generate events, but at least it allows
> for testing the ptp framework without special hardware.

So in the past, I pushed back on Richard for having something similar,
as I'm not psyched about duplicating interfaces. However, your
implementation is CLOCK_MONOTONIC_RAW instead of CLOCK_REALTIME and it
keeps the adjustments internal, I'm not as opposed.

So I think having such test driver is probably reasonable, but please
make it more explicit that it is just a testing driver, and not
something someone should try to use.

> +
> +struct ixp_clock {
> + struct ptp_clock *ptp_clock;
> + struct ptp_clock_info caps;
> + s64 offset_ns;
> + struct timespec last_timestamp;
> + s32 freq;
> +};

Probably should rename things from ixp_*

thanks
-john