Re: [PATCH] Platform: add Samsung Laptop platform driver

[Greg KH <greg@kroah.com>]

On Fri, Mar 11, 2011 at 10:20:41PM +0200, Nikolai Kondrashov wrote:
> On 03/11/2011 09:34 PM, Greg KH wrote:
> >Ok, this shows you are not loading the driver I sent to you, this is the
> >"original" one I sent, which will fail for your machine.
> Sorry, I didn't know the old version was still there.
> For some reason until I removed the staging samsung-laptop from the
> Makefile, the new one didn't get installed.
> 
> >You need to build and install the one I sent you.
> Done. So far tested on n230 only.
> 
> It fails to insert without "force" with the same message. With force it
> installs, but doesn't seem to work, at least for brightness buttons.

The brightness button hookup is in userspace, and odds are that's not
working right, you need newer gnome to handle that.

But, when you insert this with "debug=1" does the screen turn off and
then on?

You can also go into the /sys/class/backlight/samsung/ directory and
mess with the backlight values in the files to see if it gets brighter
and dimmer.  If that works, then the driver is working properly.

I'll work on getting the "force" thing to work properly, as I think I'll
just enable this for all Samsung laptops as Matthew recommends.

thanks,

greg k-h