public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Indan Zupancic <indan@nul.nu>, Arnd Bergmann <arnd@arndb.de>,
	Sage Weil <sage@newdream.net>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>,
	akpm@linux-foundation.org, linux-api@vger.kernel.org,
	mtk.manpages@gmail.com, viro@zeniv.linux.org.uk, hch@lst.de,
	l@jasper.es
Subject: Re: [PATCH v3] introduce sys_syncfs to sync a single file system
Date: Sat, 12 Mar 2011 09:32:17 -0800	[thread overview]
Message-ID: <20110312173217.GA24981@kroah.com> (raw)
In-Reply-To: <20110312021001.GA16833@elie>

On Fri, Mar 11, 2011 at 08:10:01PM -0600, Jonathan Nieder wrote:
> Indan Zupancic wrote:
> 
> > I'm not pushing for any official convention, just what seems good taste.
> 
> In cases like this, conventions (consistency and best practices) are
> very important.
> 
> > Less code added, less bloat. Architecture independent, no need to update
> > all system call tables everywhere (all archs, libc versions and strace).
> > Two files changed, instead of 7 (which only hooks up x86).
> 
> Thanks for explaining.  Those do seem like good reasons to use a ioctl
> instead of a new syscall.

No, make it a syscall, it's more obvious and will be documented much
better.

thanks,

greg k-h

  parent reply	other threads:[~2011-03-12 17:41 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03  6:35 [RFC] introduce sys_syncat to sync a single file system Sage Weil
2011-03-03  7:22 ` Jonathan Nieder
2011-03-03  8:54   ` Aneesh Kumar K. V
2011-03-07 23:17     ` [RFC] introduce sys_syncfs to sync a single file system (v2) Sage Weil
2011-03-08  5:27       ` Aneesh Kumar K. V
2011-03-10 14:56         ` Arnd Bergmann
2011-03-10 19:28           ` Sage Weil
2011-03-10 19:31       ` [PATCH v3] introduce sys_syncfs to sync a single file system Sage Weil
2011-03-10 22:08         ` Arnd Bergmann
2011-03-11  4:44         ` Aneesh Kumar K. V
2011-03-11 11:01         ` Indan Zupancic
2011-03-11 11:55           ` Arnd Bergmann
2011-03-11 23:45             ` Indan Zupancic
2011-03-11 23:56               ` Jonathan Nieder
2011-03-12  1:53                 ` Indan Zupancic
2011-03-12  2:10                   ` Jonathan Nieder
2011-03-12  4:22                     ` Indan Zupancic
2011-03-12 17:32                     ` Greg KH [this message]
2011-03-14  1:56                       ` Indan Zupancic
2011-03-14  4:29                         ` Sage Weil
2011-03-14  9:27                           ` Indan Zupancic
2011-03-14 10:22                             ` Theodore Tso
2011-03-15 10:11                           ` Dave Chinner
2011-03-15 13:00                             ` Sage Weil
2011-03-15 15:56                             ` Andreas Dilger
2011-03-15 16:08                               ` Sage Weil
2011-03-15 20:18                               ` Andrew Morton
2011-03-14 20:10                         ` Andrew Morton
2011-03-14 20:29                           ` Artem Bityutskiy
2011-03-14 21:11                           ` Ted Ts'o
2011-03-14 21:20                             ` Andrew Morton
2011-03-14 23:17                               ` Ted Ts'o
2011-03-14 21:22                             ` Arnd Bergmann
2011-03-12  0:40               ` Ric Wheeler
2011-03-12  1:33                 ` Indan Zupancic
2011-03-12  2:52                   ` Ric Wheeler
2011-03-12  3:50                     ` Indan Zupancic
2011-03-12 12:41                       ` Ric Wheeler
2011-03-12 18:31                       ` Jeff Garzik
2011-03-14  1:31                         ` Indan Zupancic
2011-03-14  1:37                           ` Theodore Tso
2011-03-14  1:47                             ` Indan Zupancic
2011-03-14  1:45                           ` Jeff Garzik
2011-03-14  1:59                             ` Indan Zupancic
2011-03-12 19:28                       ` Artem Bityutskiy
2011-03-12 19:22                   ` Artem Bityutskiy
2011-03-14  1:38                     ` Indan Zupancic
2011-03-14  5:52                       ` Artem Bityutskiy
2011-03-13 20:59         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110312173217.GA24981@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=arnd@arndb.de \
    --cc=hch@lst.de \
    --cc=indan@nul.nu \
    --cc=jrnieder@gmail.com \
    --cc=l@jasper.es \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=sage@newdream.net \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox