public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Omar Ramirez Luna <omar.ramirez@ti.com>
Cc: l-m <linux-kernel@vger.kernel.org>,
	Felipe Contreras <felipe.contreras@nokia.com>,
	l-o <linux-omap@vger.kernel.org>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	Fernando Guzman Lugo <fernando.lugo@ti.com>,
	Tuomas Kulve <tuomas@kulve.fi>
Subject: Re: [PATCH] staging: tidspbridge: protect dmm_map properly
Date: Sat, 12 Mar 2011 09:36:26 -0800	[thread overview]
Message-ID: <20110312173626.GC24981@kroah.com> (raw)
In-Reply-To: <1299889746-16502-1-git-send-email-omar.ramirez@ti.com>

On Fri, Mar 11, 2011 at 06:29:06PM -0600, Omar Ramirez Luna wrote:
> Hi Greg,
> 
> Please consider to apply this patch in the staging tree, as the
> description says it fixes a crash in tidspbridge driver, this bug
> was already present but it seems to have surfaced by recent tests
> made by Felipe and Tuomas.
> 
> It is an urgent fix for 2.6.38.

Heh, it's funny to see such a "urgent" fix take so long to get to me :)

Is it also applicable for .37?

> More on this discussion:
> http://www.gossamer-threads.com/lists/linux/kernel/1351446
> 
> Thanks,
> - omar
> 
> From: Felipe Contreras <felipe.contreras@nokia.com>
> 
> We need to protect not only the dmm_map list, but the individual
> map_obj's, otherwise, we might be building the scatter-gather list with
> garbage. So, use the existing proc_lock for that.
> 
> I observed race conditions which caused kernel panics while running
> stress tests, also, Tuomas Kulve found it happening quite often in
> Gumstix Over. This patch fixes those.
> 
> Cc: Tuomas Kulve <tuomas@kulve.fi>
> Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>

How about I send it to Linus for .39 and then add it to the .38-stable
tree when it comes out?

thanks,

greg k-h

  reply	other threads:[~2011-03-12 17:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-12  0:29 [PATCH] staging: tidspbridge: protect dmm_map properly Omar Ramirez Luna
2011-03-12 17:36 ` Greg KH [this message]
2011-03-12 23:42   ` Felipe Contreras
2011-03-13  1:06     ` Greg KH
2011-03-14 15:33       ` Felipe Contreras
2011-03-14 15:53         ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2010-12-20 17:12 Felipe Contreras
2010-12-20 18:30 ` Kanigeri, Hari
2010-12-20 18:43   ` Felipe Contreras
2011-03-07 18:02 ` Felipe Contreras
2011-03-07 18:14   ` Ohad Ben-Cohen
2011-03-07 18:48   ` Greg KH
2011-03-07 19:29   ` Ramirez Luna, Omar
2011-03-07 21:48     ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110312173626.GC24981@kroah.com \
    --to=greg@kroah.com \
    --cc=felipe.contreras@nokia.com \
    --cc=fernando.lugo@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=omar.ramirez@ti.com \
    --cc=tuomas@kulve.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox