From: Greg KH <greg@kroah.com>
To: andy.green@linaro.org
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
patches@linaro.org
Subject: Re: [RFC PATCH 1/4] PLATFORM: introduce structure to bind async platform data to a dev path name
Date: Sun, 13 Mar 2011 09:14:35 -0700 [thread overview]
Message-ID: <20110313161435.GA10718@kroah.com> (raw)
In-Reply-To: <4D7CA900.2070302@linaro.org>
On Sun, Mar 13, 2011 at 11:22:40AM +0000, Andy Green wrote:
> On 03/13/2011 01:03 AM, Somebody in the thread at some point said:
>
> >>>Using device paths for this purpose seems to be very fragile to me. Isn't
> >>>there any better solution?
> >>
> >>Given that this targets board definition files which commonly do the
> >>platform_add_device for the USB bus controller synchronously, and
> >>the bus-connected devices it is aimed at are soldered on to the
> >>board connected to specific bus controllers, the bus paths are
> >>completely deterministic.
> >
> >No they are not.
> >
> >The physical layout is deterministic, but the bus number, and device
> >number, is not. You are using the bus number here in this path, so that
> >is not going to work, sorry.
>
> Okay. This is not a PC we are talking about.
I know that, and again, it doesn't matter.
You CAN NOT GUARANTEE the USB device ordering of bus numbers or device
numbers. It's that simple.
> If the platform / board definition file is registering the USB hosts
> synchronously at boot time, the driver is composed into the
> monolithic kernel, there are no PCI busses or whatever on the SoC,
> the bus indexing is totally deterministic.
Not true, it could change for a number of reasons, not the least being
your kernel version changed.
So again NEVER rely on this, bad things could happen in the field when
you least expect it.
thanks,
greg k-h
next prev parent reply other threads:[~2011-03-13 16:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 22:32 [RFC PATCH 0/4] PLATFORM: Support for async platform_data Andy Green
2011-03-12 22:32 ` [RFC PATCH 1/4] PLATFORM: introduce structure to bind async platform data to a dev path name Andy Green
2011-03-12 23:29 ` Rafael J. Wysocki
2011-03-12 23:39 ` Andy Green
2011-03-13 1:03 ` Greg KH
2011-03-13 11:22 ` Andy Green
2011-03-13 12:51 ` Rafael J. Wysocki
2011-03-13 13:53 ` Andy Green
2011-03-13 16:58 ` Rafael J. Wysocki
2011-03-13 17:21 ` Andy Green
2011-03-13 20:45 ` Rafael J. Wysocki
2011-03-13 16:14 ` Greg KH [this message]
2011-03-13 17:26 ` Andy Green
2011-03-12 22:32 ` [RFC PATCH 2/4] PLATFORM: Introduce registration function for async platform data maps Andy Green
2011-03-12 22:32 ` [RFC PATCH 3/4] PLATFORM: Introduce async platform_data attach api Andy Green
2011-03-13 1:01 ` Greg KH
2011-03-13 10:41 ` Rafael J. Wysocki
2011-03-13 11:58 ` Andy Green
2011-03-13 12:53 ` Rafael J. Wysocki
2011-03-13 13:21 ` Andy Green
2011-03-13 16:15 ` Greg KH
2011-03-13 17:13 ` Andy Green
2011-03-13 17:48 ` Greg KH
2011-03-13 18:13 ` Andy Green
2011-03-13 23:26 ` Greg KH
2011-03-14 8:38 ` Andy Green
2011-03-14 20:54 ` Greg KH
2011-03-14 21:03 ` Alan Stern
2011-03-14 21:13 ` Greg KH
2011-03-14 21:10 ` Mark Brown
2011-03-14 21:59 ` Andy Green
2011-03-12 22:32 ` [RFC PATCH 4/4] PLATFORM: Add some documentation to platform docs about async platform_data Andy Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110313161435.GA10718@kroah.com \
--to=greg@kroah.com \
--cc=andy.green@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox