From: Harry Wei <jiaweiwei.xiyou@gmail.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
greg@kroah.com, joe@perches.com, akpm@linux-foundation.org
Subject: Re: [PATCH][rfc] Use int as return type of main in arch/x86/boot/main.c
Date: Mon, 14 Mar 2011 19:32:58 +0800 [thread overview]
Message-ID: <20110314113254.GA2761@gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1103132257430.9985@swampdragon.chaosbits.net>
On Sun, Mar 13, 2011 at 11:00:09PM +0100, Jesper Juhl wrote:
> I believe the return type of main should always be 'int'.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Harry Wei <harryxiyou@gmail.com>
> ---
> main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/boot/main.c b/arch/x86/boot/main.c
> index 40358c8..4b80da8 100644
> --- a/arch/x86/boot/main.c
> +++ b/arch/x86/boot/main.c
> @@ -125,7 +125,7 @@ static void init_heap(void)
> }
> }
>
> -void main(void)
> +int main(void)
> {
> /* First, copy the boot header into the "zeropage" */
> copy_boot_params();
> @@ -175,4 +175,6 @@ void main(void)
>
> /* Do the last things and invoke protected mode */
> go_to_protected_mode();
> +
> + return 0;
> }
>
>
> --
> Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
> Plain text mails only, please.
> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-03-14 11:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 22:00 [PATCH][rfc] Use int as return type of main in arch/x86/boot/main.c Jesper Juhl
2011-03-14 11:32 ` Harry Wei [this message]
2011-03-14 16:49 ` H. Peter Anvin
2011-03-14 19:04 ` Steven Rostedt
2011-03-14 23:35 ` Jesper Juhl
2011-03-14 19:03 ` Steven Rostedt
2011-03-14 22:50 ` H. Peter Anvin
2011-03-15 2:31 ` Steven Rostedt
2011-03-15 13:55 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314113254.GA2761@gmail.com \
--to=jiaweiwei.xiyou@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=jj@chaosbits.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox