From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@slimlogic.co.uk>,
kyungmin.park@samsung.com, myungjoo.ham@gmail.com,
Igor Grinberg <grinberg@compulab.co.il>
Subject: Re: [PATCH v3] Regulator: add suspend-finish API for regulator core.
Date: Mon, 14 Mar 2011 15:03:30 +0000 [thread overview]
Message-ID: <20110314150330.GE2626@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1299806039-12698-1-git-send-email-myungjoo.ham@samsung.com>
On Fri, Mar 11, 2011 at 10:13:59AM +0900, MyungJoo Ham wrote:
> The regulator core had suspend-prepare that turns off the regulators
> when entering a system-wide suspend. However, it did not have
> suspend-finish that pairs with suspend-prepare and the regulator core
> has assumed that the regulator devices and their drivers support
> autonomous recover at resume.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
We should be doing this automatically as part of the core but since
we've not done that for suspend yet it seems reasonable to apply as-is
then fix both the teardown and powerup paths together. Since the code
won't be called unless someone explicitly does so there's very little
risk here.
next prev parent reply other threads:[~2011-03-14 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 1:13 [PATCH v3] Regulator: add suspend-finish API for regulator core MyungJoo Ham
2011-03-14 15:03 ` Mark Brown [this message]
2011-03-16 11:22 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314150330.GE2626@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grinberg@compulab.co.il \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=myungjoo.ham@gmail.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox