From: Greg KH <greg@kroah.com>
To: Mike Waychison <mikew@google.com>
Cc: Matt Domsch <Matt_Domsch@dell.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Duncan Laurie <dlaurie@google.com>,
Aaron Durbin <adurbin@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Tim Hockin <thockin@google.com>, San Mehat <san@google.com>
Subject: Re: [PATCH v2 10/12] Introduce CONFIG_GOOGLE_FIRMWARE
Date: Mon, 14 Mar 2011 08:45:10 -0700 [thread overview]
Message-ID: <20110314154510.GE31340@kroah.com> (raw)
In-Reply-To: <20110312014347.6133.4388.stgit@mike.mtv.corp.google.com>
On Fri, Mar 11, 2011 at 05:43:47PM -0800, Mike Waychison wrote:
> In order to keep Google's firmware drivers organized amongst themselves,
> create a new directory for them to live in. As well, all Google
> firmware drivers are gated on CONFIG_GOOGLE_FIRMWARE=y, which defaults
> to 'n' in the kernel build.
Everything defaults to 'n' in the kernel build system, so this really
isn't a big deal :)
>
> Signed-off-by: Mike Waychison <mikew@google.com>
> ---
> drivers/firmware/Kconfig | 2 ++
> drivers/firmware/Makefile | 2 ++
> drivers/firmware/google/Kconfig | 14 ++++++++++++++
> drivers/firmware/google/Makefile | 1 +
> 4 files changed, 19 insertions(+), 0 deletions(-)
> create mode 100644 drivers/firmware/google/Kconfig
> create mode 100644 drivers/firmware/google/Makefile
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index e710424..d848b26 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -134,4 +134,6 @@ config ISCSI_IBFT
> detect iSCSI boot parameters dynamically during system boot, say Y.
> Otherwise, say N.
>
> +source "drivers/firmware/google/Kconfig"
> +
> endmenu
> diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
> index 1c3c173..6f68007 100644
> --- a/drivers/firmware/Makefile
> +++ b/drivers/firmware/Makefile
> @@ -11,3 +11,5 @@ obj-$(CONFIG_DMIID) += dmi-id.o
> obj-$(CONFIG_ISCSI_IBFT_FIND) += iscsi_ibft_find.o
> obj-$(CONFIG_ISCSI_IBFT) += iscsi_ibft.o
> obj-$(CONFIG_FIRMWARE_MEMMAP) += memmap.o
> +
> +obj-$(CONFIG_GOOGLE_FIRMWARE) += google/
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> new file mode 100644
> index 0000000..7834729
> --- /dev/null
> +++ b/drivers/firmware/google/Kconfig
> @@ -0,0 +1,14 @@
> +config GOOGLE_FIRMWARE
> + bool "Google Firmware Drivers"
> + depends on X86
> + default n
> + help
> + These firmware drivers are used by Google's servers. They are
> + only useful if you are working directly on one of their
> + proprietary servers or implementing similar firmware
> + interfaces. If in doubt, say "N".
How about dropping the "or implementing..." part of this sentance, as
that leaves a lot open for some people to justify enabling this option
for their machines, when it really isn't true at all at this point in
time.
thanks,
greg k-h
next prev parent reply other threads:[~2011-03-14 15:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 1:42 [PATCH v2 00/12] google firmware support Mike Waychison
2011-03-12 1:43 ` [PATCH v2 01/12] efivars: move efivars globals into struct efivars Mike Waychison
2011-03-12 1:43 ` [PATCH v2 02/12] efivars: Make efivars bin_attributes dynamic Mike Waychison
2011-03-12 1:43 ` [PATCH v2 03/12] efivars: parameterize efivars Mike Waychison
2011-03-12 1:43 ` [PATCH v2 04/12] efivars: Split out variable registration Mike Waychison
2011-03-12 1:43 ` [PATCH v2 05/12] efivars: Parameterize operations Mike Waychison
2011-03-12 1:43 ` [PATCH v2 06/12] efivars: Expose efivars functionality to external drivers Mike Waychison
2011-03-12 1:43 ` [PATCH v2 07/12] efivars: Add Documentation Mike Waychison
2011-03-12 1:43 ` [PATCH v2 08/12] x86: get_bios_ebda_length() Mike Waychison
2011-03-14 15:43 ` Greg KH
2011-03-12 1:43 ` [PATCH v2 09/12] x86: Better comments for get_bios_ebda() Mike Waychison
2011-03-14 15:43 ` Greg KH
2011-03-12 1:43 ` [PATCH v2 10/12] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-03-14 15:45 ` Greg KH [this message]
2011-03-14 19:49 ` Mike Waychison
2011-03-14 19:59 ` Greg KH
2011-03-14 20:06 ` Mike Waychison
2011-03-12 1:43 ` [PATCH v2 11/12] driver: Google EFI SMI Mike Waychison
2011-03-14 15:47 ` Greg KH
2011-03-14 20:01 ` Mike Waychison
2011-03-14 20:13 ` Greg KH
2011-03-14 21:09 ` Mike Waychison
2011-03-14 23:05 ` Alan Cox
2011-03-12 1:43 ` [PATCH v2 12/12] driver: Google Memory Console Mike Waychison
2011-03-14 4:54 ` H. Peter Anvin
2011-03-14 4:58 ` Tim Hockin
2011-03-14 5:02 ` H. Peter Anvin
2011-03-14 9:22 ` Ingo Molnar
2011-03-14 14:01 ` Tim Hockin
2011-03-14 14:23 ` Ingo Molnar
2011-03-14 15:47 ` Greg KH
2011-03-14 20:03 ` Mike Waychison
2011-03-14 22:46 ` H. Peter Anvin
2011-03-12 3:54 ` [PATCH v2 00/12] google firmware support Matt Domsch
2011-03-14 15:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314154510.GE31340@kroah.com \
--to=greg@kroah.com \
--cc=Matt_Domsch@dell.com \
--cc=adurbin@google.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dlaurie@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=san@google.com \
--cc=thockin@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox