Re: [PATCH v2 2.6.38-rc8-tip 7/20] 7: uprobes: store/restore original instruction.

Peter Zijlstra
2011-03-15T19:28:50Z

On Wed, 2011-03-16 at 00:28 +0530, Balbir Singh wrote:
>
> mm->owner should be under rcu_read_lock, unless the task is exiting
> and mm_count is 1. mm->owner is updated under task_lock().
>
> > Also, the assignments in kernel/fork.c and kernel/exit.c don't use
> > rcu_assign_pointer() and therefore lack the needed write barrier.
> >
>
> Those are paths when the only context using the mm->owner is single
>
> > Git blames Balbir for this.
>
> I accept the blame and am willing to fix anything incorrect found in
> the code.

:-), ok sounds right, just wasn't entirely obvious when having a quick
look.