Re: [PATCH v2 2.6.38-rc8-tip 7/20] 7: uprobes: store/restore original instruction.

Thomas Gleixner
2011-03-15T14:43:01Z

On Mon, 14 Mar 2011, Srikar Dronamraju wrote:
> static int install_uprobe(struct mm_struct *mm, struct uprobe *uprobe)
> {
> - int ret = 0;
> + struct task_struct *tsk;
> + int ret = -EINVAL;
>
> - /*TODO: install breakpoint */
> - if (!ret)
> + get_task_struct(mm->owner);

Increment task ref before checking for NULL ?

> + tsk = mm->owner;
> + if (!tsk)
> + return ret;
> +

Thanks,

tglx