Re: [PATCH v2 2.6.38-rc8-tip 4/20] 4: uprobes: Adding and remove a uprobe in a rb tree.

Steven Rostedt
2011-03-15T13:43:22Z

On Tue, 2011-03-15 at 14:38 +0100, Thomas Gleixner wrote:
> > +{
> > + if (!vma->vm_file)
> > + return 0;
> > +
> > + if ((vma->vm_flags & (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)) ==
> > + (VM_READ|VM_EXEC))
>
> Looks more correct than the code it replaces :)
>
> > + return 1;
> > +
> > + return 0;
> > +}
> > +
>
Yeah, we had this discussion already ;)

-- Steve