From: Oleg Nesterov <oleg@redhat.com>
To: Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrey Vagin <avagin@openvz.org>,
David Rientjes <rientjes@google.com>,
Frantisek Hrbata <fhrbata@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3 for 2.6.38] oom: select_bad_process: ignore TIF_MEMDIE zombies
Date: Mon, 14 Mar 2011 20:05:08 +0100 [thread overview]
Message-ID: <20110314190508.GC21845@redhat.com> (raw)
In-Reply-To: <20110314190419.GA21845@redhat.com>
select_bad_process() assumes that a TIF_MEMDIE process should go away.
But it can only go away it its parent does wait(). Change this check to
ignore the TIF_MEMDIE zombies.
Note: this is _not_ enough. Just a minimal fix.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
mm/oom_kill.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- 38/mm/oom_kill.c~2_tif_memdie_zombie 2011-03-14 18:51:49.000000000 +0100
+++ 38/mm/oom_kill.c 2011-03-14 18:52:39.000000000 +0100
@@ -311,7 +311,8 @@ static struct task_struct *select_bad_pr
* blocked waiting for another task which itself is waiting
* for memory. Is there a better alternative?
*/
- if (test_tsk_thread_flag(p, TIF_MEMDIE))
+ if (test_tsk_thread_flag(p, TIF_MEMDIE) &&
+ !p->exit_state && thread_group_empty(p))
return ERR_PTR(-1UL);
/*
next prev parent reply other threads:[~2011-03-14 19:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.00.1103011108400.28110@chino.kir.corp.google.com>
[not found] ` <20110303100030.B936.A69D9226@jp.fujitsu.com>
[not found] ` <20110308134233.GA26884@redhat.com>
[not found] ` <alpine.DEB.2.00.1103081549530.27910@chino.kir.corp.google.com>
[not found] ` <20110309151946.dea51cde.akpm@linux-foundation.org>
[not found] ` <alpine.DEB.2.00.1103111142260.30699@chino.kir.corp.google.com>
[not found] ` <20110312123413.GA18351@redhat.com>
[not found] ` <20110312134341.GA27275@redhat.com>
[not found] ` <AANLkTinHGSb2_jfkwx=Wjv96phzPCjBROfCTFCKi4Wey@mail.gmail.com>
[not found] ` <20110313212726.GA24530@redhat.com>
2011-03-14 19:04 ` [PATCH 0/3 for 2.6.38] oom: fixes Oleg Nesterov
2011-03-14 19:04 ` [PATCH 1/3 for 2.6.38] oom: oom_kill_process: don't set TIF_MEMDIE if !p->mm Oleg Nesterov
2011-03-14 19:35 ` Linus Torvalds
2011-03-14 20:31 ` Oleg Nesterov
2011-03-14 20:32 ` David Rientjes
2011-03-15 19:12 ` Oleg Nesterov
2011-03-15 19:51 ` David Rientjes
2011-03-14 20:22 ` David Rientjes
2011-03-15 18:53 ` Oleg Nesterov
2011-03-15 19:54 ` David Rientjes
2011-03-15 21:16 ` Oleg Nesterov
2011-03-14 19:05 ` Oleg Nesterov [this message]
2011-03-14 20:50 ` [PATCH 2/3 for 2.6.38] oom: select_bad_process: ignore TIF_MEMDIE zombies David Rientjes
2011-03-14 19:05 ` [PATCH 3/3 for 2.6.38] oom: oom_kill_process: fix the child_points logic Oleg Nesterov
2011-03-14 20:41 ` David Rientjes
2011-03-15 19:21 ` Oleg Nesterov
[not found] <AANLkTikOdG7iTKDKq5mCYhcVz-rgZ_F2Ja78oBCOCQ91@mail.gmail.com>
[not found] ` <alpine.DEB.2.00.1103141512310.4425@chino.kir.corp.google.com>
[not found] ` <20110315194737.GE21640@redhat.com>
[not found] ` <alpine.DEB.2.00.1103151259380.558@chino.kir.corp.google.com>
[not found] ` <20110315212754.GB28117@redhat.com>
[not found] ` <alpine.DEB.2.00.1103151530200.5099@chino.kir.corp.google.com>
[not found] ` <20110316155310.GA9797@redhat.com>
[not found] ` <alpine.DEB.2.00.1103161220110.9710@chino.kir.corp.google.com>
[not found] ` <20110316202131.GA20790@redhat.com>
[not found] ` <alpine.DEB.2.00.1103161332490.11002@chino.kir.corp.google.com>
2011-03-18 18:32 ` [PATCH 2/3 for 2.6.38] oom: select_bad_process: ignore TIF_MEMDIE zombies Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314190508.GC21845@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=fhrbata@redhat.com \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox