From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755581Ab1CNUCJ (ORCPT ); Mon, 14 Mar 2011 16:02:09 -0400 Received: from cantor.suse.de ([195.135.220.2]:33507 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187Ab1CNUCH (ORCPT ); Mon, 14 Mar 2011 16:02:07 -0400 Date: Mon, 14 Mar 2011 12:58:49 -0700 From: Greg KH To: KY Srinivasan Cc: Greg KH , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "virtualization@lists.osdl.org" , Haiyang Zhang , Mike Sterling , "Abhishek Kane (Mindtree Consulting PVT LTD)" Subject: Re: [PATCH 10/21] Staging: hv: Cleanup root device handling Message-ID: <20110314195849.GA533@suse.de> References: <1299794886-1200-1-git-send-email-kys@microsoft.com> <20110314193333.GA18944@kroah.com> <6E21E5352C11B742B20C142EB499E048019582@TK5EX14MBXC128.redmond.corp.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6E21E5352C11B742B20C142EB499E048019582@TK5EX14MBXC128.redmond.corp.microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 14, 2011 at 07:54:29PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:greg@kroah.com] > > Sent: Monday, March 14, 2011 3:34 PM > > To: KY Srinivasan > > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org; > > devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang; Mike > > Sterling; Abhishek Kane (Mindtree Consulting PVT LTD) > > Subject: Re: [PATCH 10/21] Staging: hv: Cleanup root device handling > > > > On Thu, Mar 10, 2011 at 02:08:06PM -0800, K. Y. Srinivasan wrote: > > > Now we can complete the cleanup of the root device > > > management. Use the preferred APIs for creating and > > > managing the root device. As part of this cleanup get rid > > > of the root device object from vmbus_driver_context. > > > > I don't understand, what is the "root device"? > > This would be the device under /sys/devices that all > other hyperv devices would be grouped under. > This notion of the root device existed in the existing > code; however its creation and management was > unnecessarily complicated. But that is what your new pci device should be, not a separate one. Why not use that instead? Actually, how are things looking then? You have a pci device, with no children, yet the root device has the children devices? That doesn't really make sense now does it? thanks, greg k-h