Re: [RFC-v2 07/12] iscsi-target: Add CHAP Authentication support using libcrypto

Nicholas A. Bellinger
2011-03-15T23:03:42Z

On Tue, 2011-03-15 at 11:24 +0100, Christoph Hellwig wrote:
> On Mon, Mar 14, 2011 at 04:57:04AM -0700, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> >
> > This patch adds support for libcrypto md5 based iSCSI CHAP authentication
> > support for iscsi_target_mod. This includes support for mutual and one-way
> > NodeACL authentication for SessionType=Normal and SessionType=Discovery
> > via /sys/kernel/config/target/iscsi.
> >
> > Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
> > ---
> > drivers/target/iscsi/iscsi_auth_chap.c | 502 ++++++++++++++++++++++++++++++++
> > drivers/target/iscsi/iscsi_auth_chap.h | 33 ++
> > 2 files changed, 535 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/target/iscsi/iscsi_auth_chap.c
> > create mode 100644 drivers/target/iscsi/iscsi_auth_chap.h
>
> Why aren't these files named iscsi_target_* like most others? If you prefix
> all files in a module please do it consistently, or alternatively just
> drop the prefix altogether.
>

This where shared amounst initiator code at one point.. Renaming to
iscsi_target_auth now.

Thanks,

--nab