Re: [RFC-v2 01/12] iscsi: Resolve iscsi_proto.h naming conflicts with drivers/target/iscsi

Nicholas A. Bellinger
2011-03-14T23:59:41Z

On Mon, 2011-03-14 at 17:13 -0500, Mike Christie wrote:
> On 03/14/2011 04:40 PM, Nicholas A. Bellinger wrote:
> > On Mon, 2011-03-14 at 15:59 +0100, Christoph Hellwig wrote:
> >> On Mon, Mar 14, 2011 at 04:56:58AM -0700, Nicholas A. Bellinger wrote:
> >>> From: Nicholas Bellinger<nab@linux-iscsi.org>
> >>>
> >>> This patch renames the following iscsi_proto.h structures to avoid
> >>> namespace issues with drivers/target/iscsi/iscsi_target_core.h:
> >>>
> >>> *) struct iscsi_cmd -> struct iscsi_scsi_cmd
> >>
> >> This name is not overly descriptive. Using _req/_rsp uniformly would make a
> >> lot more sense.
> >>
> >
> > Mmmm, fair point here.. I don't have a strong preference so I will
> > defer to Mike and Hannes on this (open-iscsi CC'ed). Guys is this OK
> > with you..?
> >
>
> Ok with me.

OK, I will go ahead and convert these libiscsi PDU definitions to
iscsi_scsi_req and iscsi_scsi_rsp and update patch #1 of the series for
RFC-v3.

Thanks Mike!

--nab