Re: [RFC-v2 11/12] iscsi-target: Add misc utility and debug logic

Nicholas A. Bellinger
2011-03-15T23:07:05Z

On Tue, 2011-03-15 at 11:27 +0100, Christoph Hellwig wrote:
> On Mon, Mar 14, 2011 at 04:57:08AM -0700, Nicholas A. Bellinger wrote:
> > +++ b/drivers/target/iscsi/iscsi_debug.h
> > @@ -0,0 +1,113 @@
> > +#ifndef ISCSI_DEBUG_H
> > +#define ISCSI_DEBUG_H
> > +
> > +/*
> > + * Debugging Support
> > + */
> > +
> > +#define TRACE_DEBUG 0x00000001 /* Verbose debugging */
> > +#define TRACE_SCSI 0x00000002 /* Stuff related to SCSI Mid-layer */
>
> Please use trace events for this kind of debugging.
>

<nod>, will have a closer look at Documentation/trace/events.txt

> > + spin_lock_bh(&conn->cmd_lock);
> > + list_add_tail(&cmd->i_list, &conn->conn_cmd_list);
> > + spin_unlock_bh(&conn->cmd_lock);
> > +
> > + atomic_inc(&conn->active_cmds);
>
> Seems like this counter is always maintained together with the list,
> so it should be a non-atomic type under cmd_lock.
>

This counter (was) purely information and unused beyond the atomic_inc()
+ atomic_dec(). Removing now..

--nab