From: Dan Carpenter <error27@gmail.com>
To: wwang <wei_wang@realsil.com.cn>
Cc: gregkh@suse.de, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: rts_pstor: set lun_mode in a differentplace
Date: Tue, 15 Mar 2011 15:48:45 +0300 [thread overview]
Message-ID: <20110315124844.GY2008@bicker> (raw)
In-Reply-To: <4D7F29C6.7060404@realsil.com.cn>
On Tue, Mar 15, 2011 at 04:56:38PM +0800, wwang wrote:
> 于 2011年03月15日 16:46, Dan Carpenter 写道:
> > Hm... The auto detect code is never run because chip->use_hw_setting is
> > always 0. Are you sure the right fix isn't to set chip->use_hw_setting
> > to 1?
> >
> > regards,
> > dan carpenter
> >
> Yes, setting chip->use_hw_setting is not a wise choice.
> Normally, if chip->use_hw_setting is set to 1, more configurations will
> be turned on, such as auto_delink_en.
> auto_delink_en can only work well when pcie hotplug is configured and
> pciehp.pciehp_force is set to 1. This condition can't be met in default
> kernel config by now.
> So, I have to choose to set lun_mode detection code in a different place.
>
Ok. Cool. But you're going to fix the places that use ->use_hw_setting
later on yes? For example, the rts5288 chip has the same problem earlier
in the file where the lun_mode doesn't get set correctly.
regards,
dan carpenter
prev parent reply other threads:[~2011-03-15 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 8:22 [PATCH 2/2] staging: rts_pstor: set lun_mode in a different place wei_wang
2011-03-15 8:46 ` Dan Carpenter
2011-03-15 8:56 ` [PATCH 2/2] staging: rts_pstor: set lun_mode in a differentplace wwang
2011-03-15 12:48 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315124844.GY2008@bicker \
--to=error27@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox