From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Adamson <andros@netapp.com>,
Boaz Harrosh <bharrosh@panasas.com>,
Dean Hildebrand <dhildeb@us.ibm.com>,
Fred Isaman <iisaman@citi.umich.edu>,
Mike Sager <sager@netapp.com>, Fred Isaman <iisaman@netapp.com>,
Mingyang Guo <guomingyang@nrchpc.ac.cn>,
Ricardo Labiaga <Ricardo.Labiaga@netapp.com>,
Tao Guo <guotao@nrchpc.ac.cn>, Benny Halevy <bhalevy@panasas.com>,
Trond Myklebust <trond.myklebust@fys.uio.no>
Subject: Re: linux-next: build failure after merge of the bkl-config tree
Date: Tue, 15 Mar 2011 13:59:12 +0100 [thread overview]
Message-ID: <201103151359.12569.arnd@arndb.de> (raw)
In-Reply-To: <20110315184845.1a411e67.sfr@canb.auug.org.au>
On Tuesday 15 March 2011, Stephen Rothwell wrote:
> After merging the bkl-config tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/nfs/read.c:21:28: error: linux/smp_lock.h: No such file or directory
>
> Caused by commit 64419a9b2093 ("NFSv4.1: generic read") from the nfs tree
> interacting with commit 4ba8216cd905 ("BKL: That's all, folks") from the
> bkl-config tree.
>
> I couldn't see that this include file was needed, so I applied the patch
> below (which Trond could apply to his tree, I am pretty sure). (I am not
> sure why module.h is included either.)
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 15 Mar 2011 18:37:09 +1100
> Subject: [PATCH] nfs: BKL is no longer needed, so remove the include
>
The fix is good. I have one patch in bkl-config that removes all instances
of #include <linux/smp_lock.h> treewide. Obviously that doesn't
help where new ones creep in, so we have to eliminate them one
by one.
Arnd
next prev parent reply other threads:[~2011-03-15 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 7:48 linux-next: build failure after merge of the bkl-config tree Stephen Rothwell
2011-03-15 12:46 ` Trond Myklebust
2011-03-15 12:59 ` Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-16 2:08 Stephen Rothwell
2010-11-16 9:21 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103151359.12569.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Ricardo.Labiaga@netapp.com \
--cc=andros@netapp.com \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=dhildeb@us.ibm.com \
--cc=guomingyang@nrchpc.ac.cn \
--cc=guotao@nrchpc.ac.cn \
--cc=iisaman@citi.umich.edu \
--cc=iisaman@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sager@netapp.com \
--cc=sfr@canb.auug.org.au \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox