From: Harry Wei <jiaweiwei.xiyou@gmail.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: linux-kernel@vger.kernel.org, dev.rck@gmail.com,
torvalds@linux-foundation.org
Subject: Re: [PATCH 3/6] Documentation: update header filename in CodingStyle
Date: Wed, 16 Mar 2011 13:13:13 +0800 [thread overview]
Message-ID: <20110316051311.GA3984@gmail.com> (raw)
In-Reply-To: <20110315161152.4bee194f.rdunlap@xenotime.net>
On Tue, Mar 15, 2011 at 04:11:52PM -0700, Randy Dunlap wrote:
> From: Roland Kammerer <dev.rck@gmail.com>
>
> pr_info() and pr_debug() are in linux/printk.h, not linux/kernel.h.
> Last updated is unnecessary, we have git for that.
>
> Signed-off-by: Roland Kammerer <dev.rck@gmail.com>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Harry Wei <harryxiyou@gmail.com>
> ---
> Documentation/CodingStyle | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> --- lnx-2638-rc8.orig/Documentation/CodingStyle
> +++ lnx-2638-rc8/Documentation/CodingStyle
> @@ -659,7 +659,7 @@ There are a number of driver model diagn
> which you should use to make sure messages are matched to the right device
> and driver, and are tagged with the right level: dev_err(), dev_warn(),
> dev_info(), and so forth. For messages that aren't associated with a
> -particular device, <linux/kernel.h> defines pr_debug() and pr_info().
> +particular device, <linux/printk.h> defines pr_debug() and pr_info().
>
> Coming up with good debugging messages can be quite a challenge; and once
> you have them, they can be a huge help for remote troubleshooting. Such
> @@ -819,6 +819,3 @@ language C, URL: http://www.open-std.org
> Kernel CodingStyle, by greg@kroah.com at OLS 2002:
> http://www.kroah.com/linux/talks/ols_2002_kernel_codingstyle_talk/html/
>
> ---
> -Last updated on 2007-July-13.
> -
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-03-16 5:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110315134316.465b6e2c.rdunlap@xenotime.net>
2011-03-15 23:11 ` [PATCH 2/6] Documentation: add devicetree docs index file Randy Dunlap
2011-03-15 23:11 ` [PATCH 3/6] Documentation: update header filename in CodingStyle Randy Dunlap
2011-03-16 5:13 ` Harry Wei [this message]
2011-03-15 23:12 ` [PATCH 4/6] Documentation: file handles are now freed Randy Dunlap
2011-03-15 23:12 ` [PATCH 5/6] Documentation: update cgroup pid and cpuset information Randy Dunlap
2011-03-15 23:12 ` [PATCH 6/6] sched.c: fix kernel-doc for runqueue_is_locked() Randy Dunlap
2011-03-16 13:56 ` [tip:sched/urgent] sched, kernel-doc: Fix runqueue_is_locked() description tip-bot for Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110316051311.GA3984@gmail.com \
--to=jiaweiwei.xiyou@gmail.com \
--cc=dev.rck@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox