Re: linux-next: build failure after merge of the final tree (jdelvare-hwmon tree related)

Jean Delvare
2010-10-06T07:05:57Z

Hi Stephen,

On Wed, 6 Oct 2010 15:28:31 +1100, Stephen Rothwell wrote:
> Hi ,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/hwmon/pcf8591.c: In function 'pcf8591_probe':
> drivers/hwmon/pcf8591.c:205: error: implicit declaration of function 'IS_ERR'
> drivers/hwmon/pcf8591.c:206: error: implicit declaration of function 'PTR_ERR'
>
> Caused by commit 63575f5628b811d80f81158825dbc9d3db4ac1a5 ("hwmon:
> (pcf8591) Register as a hwmon device").

Oh, right. Missing include, thanks for the heads up.

> See Rule 1 in Documentation/SubmitChecklist.

True, shame on me :(

> I have added reverted that commit (and
> 3eabb87a17ff8da477f7bf4c5a14063b68937fb1 ("hwmon: (pcf8591) Don't attempt
> to detect devices") that followed it) for today.

Fixed by now.

--
Jean Delvare