From: Arnd Bergmann <arnd@arndb.de>
To: Alexey Mikhailov <karma@galois.botik.ru>
Cc: linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: lseek() on debugfs entries in 2.6.37
Date: Wed, 16 Mar 2011 12:41:58 +0100 [thread overview]
Message-ID: <201103161241.58215.arnd@arndb.de> (raw)
In-Reply-To: <87fwqn1gsv.wl%karma@galois.botik.ru>
On Wednesday 16 March 2011, Alexey Mikhailov wrote:
> Thank you for reply. Obvious patches like this one fixed it
>
> static struct file_operations fops_timesync = {
> .owner = THIS_MODULE,
> .open = fop_open_timesync,
> .read = fop_read_timesync,
> + .llseek = default_llseek,
> };
>
> I assume there is the reason you need to specify this
> explicitly as it will break much out-of-kernel code.
Yes, this was required as a prerequisite to removing the big
kernel lock. Generally speaking, there is very little care taken
to prevent out of tree modules from breaking. If you have device
drivers that you care about, I recommend submitting them for
inclusion in drivers/staging or as a proper driver in the mainline
kernel.
Arnd
next prev parent reply other threads:[~2011-03-16 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 12:54 lseek() on debugfs entries in 2.6.37 Alexey Mikhailov
2011-03-15 14:01 ` Arnd Bergmann
2011-03-16 10:49 ` Alexey Mikhailov
2011-03-16 11:41 ` Arnd Bergmann [this message]
2011-03-15 19:36 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103161241.58215.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=karma@galois.botik.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox